Add CodeQL suppressions for false positives #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Feb 5, 2025
bgavrilMS
reviewed
Feb 19, 2025
| @@ -32,6 +32,7 @@ static void removeStateNonceCookies(HttpServletResponse httpResponse){ | |||
| Cookie stateCookie = new Cookie(MSAL_WEB_APP_STATE_COOKIE, ""); | |||
| stateCookie.setMaxAge(0); | |||
|
|
|||
| // CodeQL [java/insecure-cookie]: Suppressing CodeQL warning since this is just a sample | |||
There was a problem hiding this comment.
@Avery-Dunn - can we revisit this? Our samples should not use insecure practices.
There was a problem hiding this comment.
This is just a simpler version of the "real" sample meant to help with manual E2E testing rather than teach something, however it turns out the same code is in the real sample: https://github.com/Azure-Samples/ms-identity-msal-java-samples/blob/main/1-server-side/msal-b2c-web-sample/src/main/java/com/microsoft/azure/msalwebsample/CookieHelper.java#L30
I've just created an issue about auditing the samples to find these sorts of insecure practices: #911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CodeQL issues from #899:
AcquireTokenByInteractiveFlowSupplier: the issue was String concatenation with user input, however the URL is validated earlier in the interactive flowDefaultHttpClientManagedIdentity: the issue was setting aHostnameVerifierthat accepts all host names, however theTrustManagerthat uses the verifier only accepts a specific certificate thumbprint (this code was copied from the Azure Identity Java SDK and I discussed this behavior with them)