Chore/update to react 19 #7548
Draft
Chore/update to react 19 #7548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjenbloemsma
force-pushed
the
chore/update-to-react-19
branch
from
ee2652f to
6383620
Compare
|
What needs to be done for this to go out of draft. |
SM-OliLegg
suggested changes
Feb 19, 2025
| "@types/jest": "^29.5.0", | ||
| "@types/node": "^20.5.1", | ||
| "@types/react": "^18.2.13", | ||
| "@types/react-dom": "^18.2.6", | ||
| "@types/react": "^19.0.01", |
There was a problem hiding this comment.
Suggested change
| "@types/react": "^19.0.01", | |
| "@types/react": "^19.0.10", |
|
@arjenbloemsma we would also like to upgrade our stack to React 19 and we are stuck because of this. Are you ok accepting the suggestion so that we include this in the next release? |
|
Similar to others here, our path to React 19 is blocked due to this package. @arjenbloemsma Is this okay to be marked as ready? Is there anything we can do to assist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this is a "copy" of PR #7467 which got accidentally closed while doing an update to resolve conflicts
React 19 stable has been released on December 5th (see announcement). This PR updates the react packages to version 19 and also sets the peerDependecies to reflect this.
This change will allow msal-react to be used in projects that use react 19 and enables existing projects that use react and msal-react to upgrade to react 19.
All test succeed:
See issue #7455