Fix exception when BroadcastChannel is not available in JS Runtime #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codexeon
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
tnorling
reviewed
Feb 14, 2025
| @@ -39,6 +42,7 @@ describe("JS Runtime Nested App Auth", () => { | |||
| // Remove global properties that can be reset after test that don't have full implementations in JS Runtime | |||
| deleteGlobalProperty("crypto"); | |||
| deleteGlobalProperty("TextEncoder"); | |||
| deleteGlobalProperty("BroadcastChannel"); | |||
There was a problem hiding this comment.
To catch future issues related to globals I'd recommend creating your own jest environment that more closely approximates the JS Runtime
tnorling
approved these changes
Feb 14, 2025
codexeon
force-pushed
the
dasau/jsruntime_broadcastchannel_fix
branch
from
1795cc7 to
2588ac2
Compare
sameerag
approved these changes
Feb 20, 2025
codexeon
force-pushed
the
dasau/jsruntime_broadcastchannel_fix
branch
from
2588ac2 to
aaedddc
Compare
codexeon
force-pushed
the
dasau/jsruntime_broadcastchannel_fix
branch
from
aaedddc to
496f047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an exception when calling createNestablePublicClientApplication in JS Runtime due to BroadcastChannel not being available in that environment. Unfortunately, the JS Runtime test missed this because BroadcastChannel is now available in node by default.