Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js 15.1.7 AppRouter sample with Node 22.14.0, Npm 11 #7575

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Next.js 15.1.7 AppRouter sample with Node 22.14.0, Npm 11 #7575

wants to merge 8 commits into from

Conversation

devopsbob
Copy link

@devopsbob devopsbob commented Feb 18, 2025 •
edited
Loading

Updated dependencies and versions to align with dev head. Narrowed change impacts from my own local rebase fumble.

Invalid tenant id to obtain certificate to complete test:e2e validation.

nvm use --lts (22.14.0)
npm install -g [email protected]
choco install openssl
clone, cd
./gen_env (fails here tenant login)
npm install --legacy-peer-deps
cd lib/msal-react
npm run build:all
cd ../../samples/msal-react-samples/nextjs15-sample (on branch)
npm install --legacy-peer-deps
npm run build
npm run test:e2e

@devopsbob
Next.js 15.1.7 AppRouter sample with Node 22.14.0, Npm 11
ef46302 
Updated dependencies and versions to align with dev head. Narrowed change impacts from my own local rebase fumble.
@github-actions github-actions bot added documentation Related to documentation. samples Related to the samples apps for the library. msal-react Related to @azure/msal-react labels Feb 18, 2025
devopsbob and others added 4 commits February 20, 2025 07:52
@devopsbob
Merge branch 'dev' into nextjs15-sample-rc2
fe8dc05
@devopsbob
Correct rollup config for import instead of require
cd6e585
@devopsbob
msal-browser version 4.4.0 and allother as of today
19e8922
@devopsbob
Narrowing dependency resolution for react 19
c6dd524 
Found mixed or existing package-lock.json and node_modules folders caused dedupe to fallback nextjs15 to react 18. Delete all node_modules and all package-lock.json inside root and all workspaces before running initial npm install. Then use of npm ls react-dom shows correct overrides and correct fallback react 18 only for nextjs-sample that requires it.
@devopsbob
Copy link
Author

Fix: Most will use React 19 and only unverified child projects retain React 18.

Modify find to remove recursive force for cleanup then complete steps for build.

find . -type d -name "node_modules" -exec ls -l {} +
find . -type f -name "package-lock.json" -exec ls -l {} +
npm install
cd lib/msal-react
npm run build:all
npm test
cd ../../samples/msal-react-samples
cd nextjs15-sample
npm run build

Then see the correct dependencies resolutions.

npm ls react-dom
microsoft-authentication-libraries-for-js@ /home/devadmin/wslsrc/github/microsoft-authentication-library-for-js
├─┬ @azure/[email protected] -> ./lib/msal-react
│ ├─┬ @testing-library/[email protected]
│ │ └── [email protected] deduped
│ └── [email protected]
├─┬ [email protected] -> ./samples/msal-react-samples/b2c-sample
│ ├─┬ @mui/[email protected]
│ │ ├── [email protected] deduped
│ │ └─┬ [email protected]
│ │   └── [email protected] deduped
│ ├── [email protected]
│ └─┬ [email protected]
│   └── [email protected] deduped
├─┬ [email protected] -> ./samples/msal-node-samples/ElectronSystemBrowserTestApp
│ ├─┬ [email protected]
│ │ ├─┬ @restart/[email protected]
│ │ │ └── [email protected] deduped
│ │ └── [email protected] deduped
│ └── [email protected]
├─┬ [email protected] -> ./samples/msal-react-samples/nextjs-sample
│ ├─┬ [email protected]
│ │ └── [email protected] deduped
│ └── [email protected]
├─┬ [email protected] -> ./samples/msal-react-samples/nextjs15-sample
│ ├─┬ @mui/[email protected]
│ │ └── [email protected] deduped
│ ├─┬ [email protected]
│ │ └── [email protected] deduped
│ └── [email protected] deduped
├─┬ [email protected] -> ./samples/msal-react-samples/react-router-sample
│ └── [email protected]
└─┬ [email protected] -> ./samples/msal-react-samples/typescript-sample
  └── [email protected]

@devopsbob devopsbob mentioned this pull request Feb 20, 2025
Closed
dependabot bot and others added 3 commits February 21, 2025 10:15
@dependabot @devopsbob
Bump @octokit/request-error and @actions/github in /.github/actions/i…
6b268a7 
…ssue_template_bot (AzureAD#7572)

Bumps
[@octokit/request-error](https://github.com/octokit/request-error.js) to
5.1.1 and updates ancestor dependency
[@actions/github](https://github.com/actions/toolkit/tree/HEAD/packages/github).
These dependencies need to be updated together.

Updates `@octokit/request-error` from 2.0.3 to 5.1.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/octokit/request-error.js/releases"><code>@​octokit/request-error</code>'s
releases</a>.</em></p>
<blockquote>
<h2>v5.1.1</h2>
<h2><a
href="https://github.com/octokit/request-error.js/compare/v5.1.0...v5.1.1">5.1.1</a>
(2025-02-14)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>ReDos regex vulnerability, reported by <a
href="https://github.com/dayshift"><code>@​dayshift</code></a> (<a
href="https://github.com/octokit/request-error.js/commit/12a14f03dbfbbdc759c1c20a631b277892da09de">12a14f0</a>)</li>
</ul>
<h2>v5.1.0</h2>
<h1><a
href="https://github.com/octokit/request-error.js/compare/v5.0.1...v5.1.0">5.1.0</a>
(2024-04-05)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>upgrade <code>@octokit/types</code> to v13 (<a
href="https://github.com/octokit/request-error.js/commit/3af20bd58fea6cc349bc191c725e78e9cc021da6">3af20bd</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li><strong>security:</strong> Add provenance (<a
href="https://redirect.github.com/octokit/request-error.js/issues/416">#416</a>)
(<a
href="https://github.com/octokit/request-error.js/commit/94147e8843898e0edd2664d0c46a4f42eb4adaa4">94147e8</a>)</li>
</ul>
<h2>v5.0.1</h2>
<h2><a
href="https://github.com/octokit/request-error.js/compare/v5.0.0...v5.0.1">5.0.1</a>
(2023-09-23)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> update dependency
<code>@​octokit/types</code> to v12 (<a
href="https://redirect.github.com/octokit/request-error.js/issues/366">#366</a>)
(<a
href="https://github.com/octokit/request-error.js/commit/590fc396a48bb72b4e63f3687f1bdd27fc785a24">590fc39</a>)</li>
</ul>
<h2>v5.0.0</h2>
<h1><a
href="https://github.com/octokit/request-error.js/compare/v4.0.2...v5.0.0">5.0.0</a>
(2023-07-07)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> update dependency
<code>@​octokit/types</code> to v11 (<a
href="https://redirect.github.com/octokit/request-error.js/issues/348">#348</a>)
(<a
href="https://github.com/octokit/request-error.js/commit/372097e9b16f70d4ad75089003dc9154e304faa7">372097e</a>)</li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li><strong>deps:</strong> upgrade <code>@octokit/types</code> to
v11</li>
</ul>
<h2>v4.0.2</h2>
<h2><a
href="https://github.com/octokit/request-error.js/compare/v4.0.1...v4.0.2">4.0.2</a>
(2023-06-16)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>deps:</strong> update dependency
<code>@​octokit/types</code> to v10 (<a
href="https://redirect.github.com/octokit/request-error.js/issues/343">#343</a>)
(<a
href="https://github.com/octokit/request-error.js/commit/28b1958bb96bccd50d44b69a6769e08069dd3922">28b1958</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/octokit/request-error.js/commit/b51ed2766807a5ca59b5ba477762e84171ccca53"><code>b51ed27</code></a>
test: ReDos regex vulnerability, reported by <a
href="https://github.com/dayshift"><code>@​dayshift</code></a></li>
<li><a
href="https://github.com/octokit/request-error.js/commit/12a14f03dbfbbdc759c1c20a631b277892da09de"><code>12a14f0</code></a>
fix: ReDos regex vulnerability, reported by <a
href="https://github.com/dayshift"><code>@​dayshift</code></a></li>
<li><a
href="https://github.com/octokit/request-error.js/commit/3af20bd58fea6cc349bc191c725e78e9cc021da6"><code>3af20bd</code></a>
fix: upgrade <code>@octokit/types</code> to v13</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/94147e8843898e0edd2664d0c46a4f42eb4adaa4"><code>94147e8</code></a>
feat(security): Add provenance (<a
href="https://redirect.github.com/octokit/request-error.js/issues/416">#416</a>)</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/590fc396a48bb72b4e63f3687f1bdd27fc785a24"><code>590fc39</code></a>
fix(deps): update dependency <code>@​octokit/types</code> to v12 (<a
href="https://redirect.github.com/octokit/request-error.js/issues/366">#366</a>)</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/4b9c57ea75054f66b093fc547e94f467b824c99e"><code>4b9c57e</code></a>
ci(action): update peter-evans/create-or-update-comment digest to
46da6c0</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/710afc3553d82b0a0dc3c5d6bd5cf4c756131078"><code>710afc3</code></a>
ci(action): update peter-evans/create-or-update-comment digest to
1f6c514</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/c82c8ce59ef0d28f7e709c886a876316856cbf22"><code>c82c8ce</code></a>
ci(action): update peter-evans/create-or-update-comment digest to
223779b</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/ec24ead3f170bd248cc5b4ac48e5b2307daba68e"><code>ec24ead</code></a>
ci(action): update peter-evans/create-or-update-comment digest to
46846e5 (<a
href="https://redirect.github.com/octokit/request-error.js/issues/362">#362</a>)</li>
<li><a
href="https://github.com/octokit/request-error.js/commit/365f18db79910407c978767e4ea93c1030ccbac4"><code>365f18d</code></a>
ci(action): update actions/checkout action to v4</li>
<li>Additional commits viewable in <a
href="https://github.com/octokit/request-error.js/compare/v2.0.3...v5.1.1">compare
view</a></li>
</ul>
</details>
<br />

Updates `@actions/github` from 4.0.0 to 6.0.0
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md"><code>@​actions/github</code>'s
changelog</a>.</em></p>
<blockquote>
<h3>6.0.0</h3>
<ul>
<li>Support the latest Octokit in <code>@​actions/github</code> <a
href="https://redirect.github.com/actions/toolkit/pull/1553">#1553</a>
<ul>
<li>Drop support of NodeJS v14, v16</li>
</ul>
</li>
</ul>
<h3>5.1.1</h3>
<ul>
<li>Export default octokit options <a
href="https://redirect.github.com/actions/toolkit/pull/1188">#1188</a></li>
</ul>
<h3>5.1.0</h3>
<ul>
<li>Add additionalPlugins parameter to getOctokit method <a
href="https://redirect.github.com/actions/toolkit/pull/1181">#1181</a></li>
<li>Dependency updates <a
href="https://redirect.github.com/actions/toolkit/pull/1180">#1180</a></li>
</ul>
<h3>5.0.3</h3>
<ul>
<li>
<ul>
<li>Update to v2.0.1 of <code>@actions/http-client</code> <a
href="https://redirect.github.com/actions/toolkit/pull/1087">#1087</a></li>
</ul>
</li>
</ul>
<h3>5.0.2</h3>
<ul>
<li>Update to v2.0.0 of <code>@actions/http-client</code></li>
</ul>
<h3>5.0.1</h3>
<ul>
<li><a
href="https://redirect.github.com/actions/toolkit/pull/1037">Update
Octokit Dependencies</a></li>
</ul>
<h3>5.0.0</h3>
<ul>
<li><a
href="https://redirect.github.com/actions/toolkit/pull/783">Update
<code>@​actions/github</code> to include latest octokit
definitions</a></li>
<li><a href="https://redirect.github.com/actions/toolkit/pull/794">Add
urls to context</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a
href="https://github.com/actions/toolkit/commits/HEAD/packages/github">compare
view</a></li>
</ul>
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/AzureAD/microsoft-authentication-library-for-js/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@devopsbob
Merge branch 'AzureAD:dev' into nextjs15-sample-rc2
72994a7
@devopsbob
Merge branch 'dev' into nextjs15-sample-rc2
4663ddd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Related to documentation. msal-react Related to @azure/msal-react samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devopsbob