-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support get access token and token renewal #7595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albanx
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
… expireOn for AuthorityMetadataEntity
shenj
reviewed
Feb 26, 2025
shenj
reviewed
Feb 26, 2025
shenj
reviewed
Feb 26, 2025
shenj
reviewed
Feb 26, 2025
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/auth_flow/CustomAuthAccountData.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/auth_flow/CustomAuthAccountData.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/auth_flow/error_type/GetAccountError.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/auth_flow/error_type/GetAccountError.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts
Outdated
Show resolved
Hide resolved
shenj
reviewed
Feb 26, 2025
shenj
reviewed
Feb 26, 2025
lib/msal-custom-auth/src/get_account/auth_flow/error_type/GetAccountError.ts
Show resolved
Hide resolved
nilo-ms
reviewed
Feb 27, 2025
nilo-ms
reviewed
Feb 27, 2025
lib/msal-custom-auth/src/get_account/auth_flow/CustomAuthAccountData.ts
Outdated
Show resolved
Hide resolved
nilo-ms
reviewed
Feb 27, 2025
lib/msal-custom-auth/src/get_account/auth_flow/CustomAuthAccountData.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add support for getting an access token in the
msal-custom-auth
library.Why:
getAccessToken
to acquire token.forceRefresh=true
, then skip cache look up and only execute token renew.scopes
, then use default scopes. Otherwise, it will be used during cache lookup and renew token (as request body). It has to be at least a subset of cached access token scope.What:
CustomAuthSilentCacheClient
, reuseSilentFlowClient
originally defined in msal-browser to handle the flow mentioned above.CustomAuthSilentCacheClient
to ensure the flow works as expectedCustomAuthAuthority
to createAuthorityMetadataEntity
and set into cache storage. This is used during token look up and calling correct /token endpoint for token renewal.