Adding accessibility ids to MSAL test app #2515
Open
+51
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
juan-arias
approved these changes
Feb 6, 2025
oldalton
reviewed
Feb 8, 2025
| @@ -794,4 +795,43 @@ - (void) receivedGlobalSignoutDarwinNotification:(NSNotification *)notification | |||
| self.resultTextView.text = @"Darwin notification received from the broker SDK indicating the device is in shared mode and the current account changed."; | |||
| } | |||
|
|
|||
| - (void)addAccessibilityIdentifiers | |||
There was a problem hiding this comment.
Why not set those in storybuilder directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some UI elements in MSAL test app lack labels or identifiers. This makes it difficult to select them when running XCUITests.
This PR aims to add labels/identifiers so that we can identify them while performing XCUITests.
Type of change
Risk
Additional information