Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Comment Asking Users to Use multipleCloudsSupported #2532

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jasoncoolmax
Copy link
Member

In this PR, we update the comment to ask users not to pass in instance_aware in extraQueryParameters but to use MSALPublicClientApplicationConfig.multipleCloudsSupported instead.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@jasoncoolmax jasoncoolmax requested a review from a team as a code owner February 26, 2025 06:38
@@ -74,6 +74,7 @@ NS_ASSUME_NONNULL_BEGIN

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants