Skip to content

Commit

Permalink
Pin ubuntu 22.04 so that we can still test on Py37
Browse files Browse the repository at this point in the history
  • Loading branch information
rayluo committed Jan 27, 2025
1 parent f27f4b2 commit 388b86d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:
LAB_OBO_PUBLIC_CLIENT_ID: ${{ secrets.LAB_OBO_PUBLIC_CLIENT_ID }}

# Derived from https://docs.github.com/en/actions/guides/building-and-testing-python#starting-with-the-python-workflow-template
runs-on: ubuntu-latest # It switched to 22.04 shortly after 2022-Nov-8
runs-on: ubuntu-22.04
strategy:
matrix:
python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"]
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']

steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 4 additions & 2 deletions tests/test_cloudshell.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ def test_expected_behaviors(self):
"https://double-slash.com//scope": "https://double-slash.com/",
"https://single-slash.com/scope": "https://single-slash.com",
"guid/some/scope": "guid",
"797f4846-ba00-4fd7-ba43-dac1f8f63013/.default": # Realistic GUID
"797f4846-ba00-4fd7-ba43-dac1f8f63013"
"6dae42f8-4368-4678-94ff-3960e28e3630/.default":
# The real guid of AKS resource
# https://learn.microsoft.com/en-us/azure/aks/kubelogin-authentication#how-to-use-kubelogin-with-aks
"6dae42f8-4368-4678-94ff-3960e28e3630",
}.items():
self.assertEqual(_scope_to_resource(scope), expected_resource)

Expand Down

0 comments on commit 388b86d

Please sign in to comment.