Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update langVersion #116

Merged
merged 7 commits into from
Jan 12, 2024
Merged

update langVersion #116

merged 7 commits into from
Jan 12, 2024

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Jan 11, 2024

Edit: discussion below yielded that we could in fact update to 12.

Could only update to 11 (not 12) since this is targeting .NET 7

image
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version#defaults

@kllysng kllysng requested review from jennyf19 and jmprieur January 11, 2024 00:21
@kllysng kllysng changed the title update langVersion to 12 update langVersion Jan 11, 2024
Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennyf19
Copy link
Collaborator

What about this one: https://github.com/AzureAD/microsoft-identity-abstractions-for-dotnet/blob/main/Directory.Build.props#L28

Yes, we should be able to do 12 here.

@kllysng
Copy link
Contributor Author

kllysng commented Jan 11, 2024

What about this one: https://github.com/AzureAD/microsoft-identity-abstractions-for-dotnet/blob/main/Directory.Build.props#L28

Since it's targeting netstandard2.0;netstandard2.1;net462, I thought that langVersion 11 is the most up to date version! 🤔

@keegan-caruso
Copy link
Contributor

The langVersion that is available is based on the compiler that is installed not what you are targeting.

@keegan-caruso
Copy link
Contributor

keegan-caruso commented Jan 11, 2024

Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kllysng kllysng merged commit f3328d9 into main Jan 12, 2024
4 checks passed
@kllysng kllysng deleted the kellysong/langVer branch January 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants