Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require auth for /listen API #1236

Closed
beastoin opened this issue Nov 2, 2024 · 5 comments
Closed

Require auth for /listen API #1236

beastoin opened this issue Nov 2, 2024 · 5 comments
Assignees
@nquang29

Comments

@beastoin
Copy link
Collaborator

beastoin commented Nov 2, 2024 •
edited
Loading

I don't want anyone be able to access to the socket with a simple call wscat to /v2/listen API.

please add auth to that api
@beastoin beastoin converted this from a draft issue Nov 2, 2024
@beastoin
Copy link
Collaborator Author

beastoin commented Nov 2, 2024

@nquang29 welcome to the party. yours.

@vincentkoc vincentkoc mentioned this issue Nov 3, 2024
Open
@vincentkoc
Copy link
Contributor

vincentkoc commented Nov 3, 2024 •
edited
Loading

FYI possible breaking changes on #1238 - easier to add my changes as some of the auth is tested there.

@nquang29 nquang29 mentioned this issue Nov 18, 2024
Merged
@nquang29
Copy link
Collaborator

MR:

@beastoin
Copy link
Collaborator Author

MR:

comments sent

beastoin added a commit that referenced this issue Nov 19, 2024
@beastoin
chore: add auth for api v2/listen (#1355)
2c9ac5f 
#1236
@beastoin beastoin moved this to In review in omi TODO Nov 19, 2024
@beastoin
Copy link
Collaborator Author

it works great, thanks @nquang29

@github-project-automation github-project-automation bot moved this from In review to Done in omi TODO Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nquang29 nquang29

Labels
None yet
Projects
omi TODO
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vincentkoc @beastoin @nquang29