Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add auth for api v2/listen #1355

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

nquang29
Copy link
Collaborator

@beastoin
Copy link
Collaborator

1/ app changes look bad, just simple as adding the header to all /listen request (you could ask Duong for more help)
2/ backend needs the backward compatible, v3/ pls

@nquang29 fighting

@beastoin
Copy link
Collaborator

beastoin commented Nov 18, 2024

context: we dont need to protect the v2/ because it will add the high level of complexity to the codebase. just launch the new v3/ then deprecate the v2/ someday.

@nquang29
Copy link
Collaborator Author

@beastoin pls help me review again

@beastoin
Copy link
Collaborator

lgtm @nquang29 🥳

@beastoin beastoin merged commit 2c9ac5f into BasedHardware:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants