Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API's timeouts and /memories #1570

Open
beastoin opened this issue Dec 21, 2024 · 7 comments
Open

API's timeouts and /memories #1570

beastoin opened this issue Dec 21, 2024 · 7 comments
Assignees
@nquang29
Labels
backend Backend Task (python) flutter flutter work

Comments

@beastoin
Copy link
Collaborator

beastoin commented Dec 21, 2024 •
edited
Loading

Image

2 problems:

  1. API doesn't have timeout. It could lead to the whole system outage -> APIs should have the timeout limits.
  2. API /memories is slow, p99 in minutes -> should be in Ms.
@beastoin beastoin converted this from a draft issue Dec 21, 2024
@beastoin beastoin changed the title API's timeout management and /messages API's timeouts and /messages Dec 21, 2024
@beastoin beastoin added backend Backend Task (python) flutter flutter work labels Dec 21, 2024
@beastoin beastoin moved this to To do in omi TODO Dec 23, 2024
@beastoin beastoin moved this from To do to In progress in omi TODO Dec 30, 2024
@beastoin
Copy link
Collaborator Author

@nquang29 sry, not /messages. it's /memories 🫣

@krishpranav
Copy link

Hi, is this issue still open?

@beastoin beastoin changed the title API's timeouts and /messages API's timeouts and /memories Dec 31, 2024
@beastoin
Copy link
Collaborator Author

yes @krishpranav . feel free to ask / colab with @nquang29 , looking fwd ☺️

@krishpranav
Copy link

how to contact @nquang29? is it on discord or github issue?. i am looking forward to fix the issue in this project.

@beastoin
Copy link
Collaborator Author

beastoin commented Jan 2, 2025

DM'ed in discord

@krishpranav
Copy link

I haven't received any. I've recently texted on the tasks-and-bounty channel.

@nquang29 nquang29 mentioned this issue Jan 4, 2025
Open
@nquang29
Copy link
Collaborator

nquang29 commented Jan 4, 2025

MR:
1570

@beastoin beastoin moved this from In progress to In review in omi TODO Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nquang29 nquang29

Labels
backend Backend Task (python) flutter flutter work
Projects
omi TODO
Status: In review
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beastoin @krishpranav @nquang29