-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add timeout for api #1638
base: main
Are you sure you want to change the base?
Conversation
gm 1/ can we customize the timeout for specific routes ? e.g. GET request - 30s, POST/PATCH/DELETE 5m 2/ does the timeout work for both sync and async route func ? 3/ double checking the app to ensure they don't need the full transcript segments via /memories api. then do some necessary changes on the app, backward compatible must. 4/ snake case pls 5/ > await getConversations(limit: 10000, offset: 0, segmentLimit: 10000); // 10k for now |
1/ updated, can custom with specific routes 2/ i found docs of fastapi that fastapi automatically wraps synchronous route functions in asyncio, so its work for both sync and async route 3/ updated 4/ updated 5/ i'll have another MR to solve this issue @beastoin pls help me to review again |
1/ ok |
2317444
to
ac328e5
Compare
3/ updated. @beastoin pls help me review |
No description provided.