Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect to the chat when click on a notification #1359

Merged
merged 2 commits into from
Nov 19, 2024
Merged

redirect to the chat when click on a notification #1359

merged 2 commits into from
Nov 19, 2024

Conversation

chiemduong97
Copy link
Collaborator

@chiemduong97 chiemduong97 mentioned this pull request Nov 19, 2024
Closed
@beastoin
Copy link
Collaborator

1/ why dont you use home provider > selectedIndex ?

@chiemduong97 ^

@chiemduong97
Copy link
Collaborator Author

1/ why dont you use home provider > selectedIndex ?

@chiemduong97 ^

@beastoin ok I got it, actually i did use it at first but errors because call notifyListeners () when during build.But I've fixed it and I'll commit it now.

@beastoin
Copy link
Collaborator

1/ ✅

lgtm @chiemduong97 🥳

2/ you could also simplify this code block a bit https://github.com/BasedHardware/omi/pull/1359/files#diff-2ab85b8834f6a7ae24e568e9f383a1246ad7bdf8136b55b5d352e2efe1851de6R140-R151 try harder :)

@beastoin beastoin merged commit 34159d6 into BasedHardware:main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiemduong97 @beastoin