Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMI Apps - rework webview & pinned apps #1709 #1712

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Neotastisch
Copy link
Contributor

Tests successful, see video below.

screen-20250118-191428.mp4

@Neotastisch Neotastisch mentioned this pull request Jan 18, 2025
app/lib/pages/browser/page.dart Outdated Show resolved Hide resolved
app/lib/pages/browser/page.dart Outdated Show resolved Hide resolved
@Neotastisch Neotastisch requested a review from francip January 19, 2025 01:36
@Neotastisch Neotastisch changed the title OMI Apps - Added WebView for fast view of data #1709 OMI Apps - rework #1709 Jan 19, 2025
@Neotastisch
Copy link
Contributor Author

WhatsApp Bild 2025-01-19 um 13 18 06_6e56450e
also added app pinning & improved usability principals for the app page (better separation of individual apps)

@Neotastisch
Copy link
Contributor Author

wont be able to complete the thumbnail task though

@mdmohsin7 mdmohsin7 self-requested a review January 20, 2025 10:47
.gitignore Outdated Show resolved Hide resolved
app/lib/pages/apps/widgets/app_section_card.dart Outdated Show resolved Hide resolved
app/lib/pages/apps/app_detail/app_detail.dart Outdated Show resolved Hide resolved
app/lib/pages/apps/app_detail/app_detail.dart Outdated Show resolved Hide resolved
app/lib/pages/browser/page.dart Show resolved Hide resolved
@Neotastisch
Copy link
Contributor Author

note: cant test the featured apps since it doesnt show up for me. should be fixed though

@Neotastisch Neotastisch requested a review from mdmohsin7 January 20, 2025 12:01
Copy link
Collaborator

@francip francip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though I am not the best at Flutter layout, so take it with a grain of salt. :-)

@kodjima33
Copy link
Collaborator

kodjima33 commented Jan 21, 2025

@Neotastisch I need to see the updated demo video of how this looks like before merging

@Neotastisch
Copy link
Contributor Author

@francip please do not approve changes, do not push this into production

@Neotastisch I need to see the updated demo video of how this looks like

Check telegram please

@beastoin
Copy link
Collaborator

hi man @Neotastisch , could you share the latest ver here. don't forget to double-check the requirements . keep the change minimal so that we are all on the same page; it's much easier for reviewing as well 💪

Screenshot 2025-01-21 at 11 00 30

@Neotastisch
Copy link
Contributor Author

Neotastisch commented Jan 21, 2025 via email

@Neotastisch
Copy link
Contributor Author

hi man @Neotastisch , could you share the latest ver here. don't forget to double-check the requirements . keep the change minimal so that we are all on the same page; it's much easier for reviewing as well 💪

Screenshot 2025-01-21 at 11 00 30

Oh and I'm now doing that issue exactly, I'm not doing the thumbnails. Only the in-app changes.

@Neotastisch
Copy link
Contributor Author

Tried but am not able to do backend chabges

@Neotastisch
Copy link
Contributor Author

It's not a paid bounty anyway so should be alright

@Neotastisch Neotastisch changed the title OMI Apps - rework #1709 OMI Apps - rework webview & pinned apps #1709 Jan 21, 2025
@Neotastisch
Copy link
Contributor Author

screen-20250121-195206.mp4

(Ignore the two i icons, that was fixed)

@beastoin
Copy link
Collaborator

screen-20250121-195206.mp4

(Ignore the two i icons, that was fixed)

man, Neo. i know you are busy and i am happy when you have the obsession on seeing this happen on the omi app even though it's not a paid task. but i need you to deliver your high-quality work so that you can get paid.

i am sorry to say that this implementation is not good enough. i don't want to be a gatekeeper who always pointing out the flaws on the work of good guys who want to contribute and help build omi up. but you know that's also my responsibility to ensure the omi app works well and meets high standards. it's not about the code; it's about the product.

so, let's start with a good video that reflect all your best on this ticket. we will give feedback on it, again the app, not code. when we all agree that the app is good. i will take a look at the code and help you improve it.

for example:

  1. the new setup steps UI is not better than the old one. what problem do you want to resolve ?
Screenshot 2025-01-25 at 10 17 37
  1. what's these icons ?
Screenshot 2025-01-25 at 10 21 29

overall, it's super hard for me to imagine the flow of >rework webview & pinned apps. you should make it obvious for the user.

if you want to get paid, my advice is to make it obvious to the team that your work is a valuable and high-quality.

no worries, i'm a friend, who can help you improve your skill, not your boss.

@Neotastisch

@Neotastisch
Copy link
Contributor Author

i do not need to be paid for this, i simply want that functionality myself.

  1. i wanted to improve the design of the setup steps. It has the same functionality but is more self-explanatory that way
  2. The top icons are:
    i: Switch between WebView and app details page (note: in the current code there is only one i, that was a bug when i recorded the video)
    pin: pin to top of apps page
    three dots (only when owner of the app): edit app & share
    share (only when not owner of the app): share

all of the icons below is the webview (so that one is the navigation bar in the brain app example)

i showed everything i changed in the video. i did not think it was worth it recording a video since i only changed the duplicate i's

@Neotastisch
Copy link
Contributor Author

screen-20250125-134630.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants