-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1768 : Add a notification to charge device when battery is smaller than 20% #1797
Fixes #1768 : Add a notification to charge device when battery is smaller than 20% #1797
Conversation
1/ can you drop a demo video ? |
1.) Right now, I do not have a device with me to test it perfectly. I need help from the person having device to test it, That is why _hasLowBatteryAlerted is set to false when device is reconnected again and the app is in foreground/background 3.) Yup, will do it now. But i wanted to know if it worked well with the device |
1/ could you find the people in our community yourself ? http://omi.discord.com . testing is a must. |
1/ yeah will find out and update |
@mdmohsin7 |
@joshijoe05 it works! Tested quite a few times (I guess around 8-10), and 2 times I got the notification twice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls set the line length to 120 in your code editor
@mdmohsin7 |
1/ are you done ? |
1/ yes done its working |
lgtm @joshijoe05 / congratulation 🚀 |
claim #1768
Fixes #1768
This PR introduces a notification alert when the connected device's battery drops below 20%. It ensures users are notified once per connection session to prevent spamming while handling reconnections properly.