fix: pluging schema merger type

Bekacru · Jul 25, 2024 · 7c83e6e · 7c83e6e
1 parent 23e310e
commit 7c83e6e
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/packages/better-fetch/src/create-fetch/index.ts b/packages/better-fetch/src/create-fetch/index.ts
@@ -2,7 +2,7 @@ import { z } from "zod";
 import { betterFetch } from "../fetch";
 import { BetterFetchPlugin } from "../plugins";
 import type { BetterFetchOption } from "../types";
-import { methods } from "./schema";
+import { createSchema, methods } from "./schema";
 import type { BetterFetch, CreateFetchOption } from "./types";
 
 const applySchemaPlugin = (config: CreateFetchOption) =>

diff --git a/packages/better-fetch/src/create-fetch/types.ts b/packages/better-fetch/src/create-fetch/types.ts
@@ -120,8 +120,8 @@ type UnionToIntersection<U> = (U extends any ? (x: U) => void : never) extends (
 export type PluginSchema<P> = P extends BetterFetchPlugin
 	? P["schema"] extends Schema
 		? P["schema"]
-		: undefined
-	: undefined;
+		: {}
+	: {};
 
 export type MergeSchema<Options extends CreateFetchOption> =
 	Options["plugins"] extends Array<infer P>

diff --git a/packages/better-fetch/src/test/create.test.ts b/packages/better-fetch/src/test/create.test.ts
@@ -499,4 +499,28 @@ describe("plugin", () => {
 			}),
 		);
 	});
+
+	it("shouldn't break the type on plugin with no schema plugin a schema defined", async () => {
+		const f = createFetch({
+			plugins: [
+				{
+					id: "test",
+					name: "Test",
+				},
+			],
+			schema: createSchema(
+				{
+					"/path": {
+						output: z.object({
+							message: z.string(),
+						}),
+					},
+				},
+				{
+					strict: true,
+				},
+			),
+		});
+		expectTypeOf(f).parameter(0).toMatchTypeOf<"/path">();
+	});
 });