chore: Github Action to mount Google Maps API key via Github Secrets #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yukthiw
changed the title
Yukthiw
changed the title
mwkyuen
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM! I can't see the secrets and variables under Settings.
@asherpasha are you able to add the Google Maps API key with the name VITE_MAPS_API_KEY?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does nothing atm but once Google maps key is added as a github secret this will be mounted such that it will be available to our Github pages deployment. The key will also need to be made available to prod @asherpasha can you handle this?