Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed caching of EFP viewdata #140

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

Yukthiw
Copy link
Collaborator

@Yukthiw Yukthiw commented Aug 20, 2024

Closes #139

Issue was fixed by removing un-used field in EFP ViewData causing the object to be unserializable

Copy link
Contributor

@asherpasha asherpasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator

@y330 y330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works ✅

Copy link
Collaborator

@y330 y330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merge

@Yukthiw Yukthiw merged commit bc14f2f into staging Aug 28, 2024
4 checks passed
@mwkyuen mwkyuen deleted the yukthiw/fix-caching-problems branch December 18, 2024 15:24
@mwkyuen mwkyuen restored the yukthiw/fix-caching-problems branch December 18, 2024 15:24
@mwkyuen mwkyuen deleted the yukthiw/fix-caching-problems branch December 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFP Data not properly being cached
3 participants