Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vanilla entity models #646

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

MiraculixxT
Copy link

@MiraculixxT MiraculixxT commented Jan 20, 2025

Add more entity models to the new entity renderer by BlueMap. Draft until most entities are covered (or i run out of time)

Entities in this PR

  • Chicken (adult/baby)
  • Pig (adult/baby)
  • Cod
  • Salmon
  • Tropical fish
  • Pufferfish
  • Bee (adult/baby)
  • Llama (all variants + chest, missing carpet)
  • Fox (orange, white, missing baby)

@TBlueF
Copy link
Member

TBlueF commented Jan 22, 2025

I allowed myself to commit a proposal in here on how to handle the entity-data based models for now:
image
=)

I think i prefer handling it in this (hardcoded) way for now, instead of inventing an entirely new and complex data-driven model.
Mostly because a data-driven approach would:

  • still need a ton of hardcoded helpers/value-loaders to load the correct state/data from a specific entity-type
  • be overly complex to implement
  • most likely overengineered for the actual use it would be (i don't expect many resource-packs actively supporting bluemaps custom entity-model format)

Also if/once mojang decides to add an official data-driven format for entity-models, we will need to switch to that.

I think this "hardcoded" way of adding a simple custom renderer per entity-type is the easiest and most flexible way right now :)

Any thoughts about this are still very welcome!

@TBlueF TBlueF changed the base branch from feat/entity to master January 23, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants