-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tunnel issue #1370
Open
mcampa
wants to merge
1
commit into
BrowserSync:master
Choose a base branch
from
mcampa:tunnelBug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix tunnel issue #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyone wants to comment on this issue? |
@mcampa looks great thanks! I just need to create a test-case for it :) |
Do we have any update on this PR ? |
@shakyShane any updates on this PR ? |
junedkazi
pushed a commit
to junedkazi/browser-sync
that referenced
this pull request
Jan 15, 2018
junedkazi
pushed a commit
to junedkazi/browser-sync
that referenced
this pull request
Jan 15, 2018
@shakyShane just wanted to follow up on this - we'd love to move back to using canonical browser-sync and this is our only reason for maintaining a fork today |
shakyShane
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently BrowserSync tries to refresh the browser before
bs.io
is defined causing the following issues:The issue happens when option
tunnel: true
This fixes the issue and the tunnel is started with no issues