don't eat text node wrappers that have components, bindings, or properties #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties we have code for converting Builder.io content to Mitosis where we skip simple unstyled wrapper divs around text we neglected tho to make sure we don't skip (aka gobble) layers that have other important things - like components, properties, or bindings this should fix this, making sure we only eat parents around text if they are purely a `<div>` tag with no style, properties, component, etc as originally intended
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cc53e64. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
samijaber
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have code for converting Builder.io content to Mitosis where we skip simple unstyled wrapper divs around text
we neglected tho to make sure we don't skip (aka gobble) layers that have other important things - like components, properties, or bindings
this should fix this, making sure we only eat parents around text if they are purely a
<div>tag with no style, properties, component, etc as originally intended