-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[angular]: change detection strategy and sanitize inner html support from useMetadata #1690
feat[angular]: change detection strategy and sanitize inner html support from useMetadata #1690
Conversation
View your CI Pipeline Execution ↗ for commit 26ef327.
☁️ Nx Cloud last updated this comment at |
🦋 Changeset detectedLatest commit: 26ef327 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
```ts | ||
useMetadata({ | ||
angular: { | ||
sanitizeInnerHTML: true, // doesn't use the sanitizer.bypassSecurityTrustHtml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the comment say the opposite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samijaber by default we are bypassing sanitization of innerHTML but when sanitizeInnerHTML
is true in useMetadata
it will just use innerHTML=code
where Angular sanitizes content by default. Let me know if this is confusing and we should update the naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging this for now, we can update the name later if it's confusing
Description
Adds support for:
changeDetection
sanitizeInnerHTML
Fixes adding multiple hooks inside compileContext - earlier it used to be an array so it added
,
within the hooks in the code.Jira
https://builder-io.atlassian.net/browse/ENG-8013
https://builder-io.atlassian.net/browse/ENG-8402
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.