fix: bound call expression styles are preserved in Builder generator #1694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fixing an issue where dynamic styles were not mapped to bindings I inadvertently broke a usecase where a function call could be bound to get the styles (I.e.
style={state.getStyles()}
. This PR resolves the issue by ensuring that call expressions can be set as styles.It's possible that I am missing other use cases here, so I added a console warning whenever invalid styles are dropped so it's a bit more obvious that this is happening in the future.
Failing test example:
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.