-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support vuepress v2 #42
Conversation
BREAKING CHANGE: remove vuepress-plugin-code-copy "You cannot use other plugins in your plugin anymore, which avoids lots of potential issues caused by plugin nesting. If your plugin depends on other plugins, you should list them in the docs." fix #41
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 69.46% 60.74% -8.72%
==========================================
Files 5 5
Lines 131 107 -24
Branches 26 26
==========================================
- Hits 91 65 -26
- Misses 34 35 +1
- Partials 6 7 +1
Continue to review full report at Codecov.
|
use [email protected], use vuepress's highLight, copy code from codesandbox-import-utils/lib/api/define because of esm
src/client/OnlineEdit.vue
Outdated
@@ -48,7 +48,7 @@ import { | |||
PLATFORM_TIP_MAP, | |||
} from './constants' | |||
|
|||
const vueJs = 'https://unpkg.com/vue/dist/vue.js' | |||
const vueJs = 'https://unpkg.com/vue@2.6.14/dist/vue.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using Vue 2 as default?
BREAKING CHANGE: remove vuepress-plugin-code-copy
"You cannot use other plugins in your plugin anymore, which avoids lots of
potential issues caused by plugin nesting. If your plugin depends on other plugins, you should list
them in the docs."
fix #41
$ npm i -D vuepress-plugin-demo-code@next # OR $ yarn add -D vuepress-plugin-demo-code@next