Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and Add Bruno Collection for REST APIs #1988

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

zubeydecivelek
Copy link
Contributor

  • Added Table of Contents to the README for better navigation.
  • Included the new Publish Video through REST API section in the README with detailed steps.
  • Added the exported Bruno REST API collection to the repository.

README.rst Outdated Show resolved Hide resolved
Copy link

@anikachurilova anikachurilova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you! 🥇

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
- body
- Language of the video.
- Optional
* - **featured**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this available for anyone or only for admins? If for admins, then we should either remove this from here or specify that it's only open for the admins.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right it's for admins, I'm removing. Thank you!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be useful for the admins as well. It's ok to keep it, but specify that the access to the action is restricted 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zubeydecivelek this is restricted to the egroups specified here

README.rst Show resolved Hide resolved
- file
- body
- The file to be uploaded.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should differentiate the Body parameters and the Queary parameters. So that it's more understandable that in some requests users don't need to provide a body and the query is enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're differentiated using the Location column in the table

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see. Thank you for explaining! Then this is fine by me, I don't know maybe @jrcastro2 has some other opinion (reviewed together)

"params": [],
"body": {
"mode": "json",
"json": "{\n \"_access\": {\n \"update\": [\n \"[email protected]\",\n \"[email protected]\" //Update the access according to category\n ],\n // If you want to restrict the video, update access read\n \"read\": [\n \"[email protected]\"\n ]\n\n }\n}\n\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add here dummy egroups instead?

README.rst Outdated
* - **featured**
- boolean
- body
- Whether the video is featured. (Only available for admins.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

@zubeydecivelek zubeydecivelek force-pushed the main branch 3 times, most recently from 6f913c6 to cd54808 Compare December 4, 2024 13:12
@zzacharo zzacharo merged commit c17d8f2 into CERNDocumentServer:main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants