Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to wheel building #175

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Updates to wheel building #175

merged 2 commits into from
Feb 19, 2025

Conversation

tskisner
Copy link
Member

@tskisner tskisner commented Feb 19, 2025

  • Bump vendored version of boost to 1.87, to enable support for numpy-2.

  • Bump cibuildwheel version and add a dependabot workflow to keep actions up to date.

  • Add a fix for macos wheel builds (see macOS: venvs lacking python3-config causes some builds to fail pypa/cibuildwheel#2021)

  • Add python-3.13 to the wheel build matrix.

  • Change no-as-needed linking option to be based on OS flavor rather than compiler.

  • Compile libflac as well as boost when building wheels. Bump this vendored version to 1.5.0 which includes threaded compression.

- Bump vendored version of boost to 1.87, to enable support for numpy-2.

- Bump cibuildwheel version and add a dependabot workflow to keep actions
  up to date.

- Add a fix for macos wheel builds (see pypa/cibuildwheel#2021)

- Add python-3.13 to the wheel build matrix.

- Change no-as-needed linking option to be based on OS flavor rather than
  compiler.

- Compile libflac as well as boost when building wheels.  Bump this vendored
  version to 1.5.0 which includes threaded compression.
@tskisner tskisner requested a review from arahlin February 19, 2025 06:24
@tskisner
Copy link
Member Author

Just a note that I triggered the wheel checks here. I removed the netcdf support on the macos wheels to avoid bringing in homebrew dependencies, but I can try to re-enable that and see if anything breaks.

@arahlin arahlin requested a review from nwhitehorn February 19, 2025 07:53
@tskisner tskisner requested a review from arahlin February 19, 2025 20:18
Copy link
Member

@arahlin arahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for sorting this out!

Should remove comments about netcdf from the PR summary, otherwise this looks like it's ready to merge.

@tskisner tskisner merged commit 66f373d into CMB-S4:master Feb 19, 2025
@tskisner tskisner deleted the wheel_updates branch February 19, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants