Move NodeType to its own file out of chia.server

[richardkiss]

Purpose:

I've been trying out the tach tool, and it works really well. It's been helpful in finding files that are in the wrong place. This is another one.

This patch moves NodeType to chia.types which means chia.util no longer needs to depend upon chia.server (which seems pretty obviously bad).

Lots of other files import NodeType from chia.server.outbound_message (about 116). To keep this patch short, I've left the import in chia.server.outbound_message so I don't have to make 116 changes at this point, which would be a distraction in evaluating the idea here.

There are a couple other options: move the entire file chia/server/outbound_message.py to chia/types/outbound_message.py. We could also split out Message into its own file and/or move it to chia/types. What do you @arvidn @altendky think about these options?

Current Behavior:

New Behavior:

Testing Notes:

[coveralls-official]

Pull Request Test Coverage Report for Build 13020383560

Details

• 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
• 11 unchanged lines in 5 files lost coverage.
• Overall coverage increased (+0.04%) to 91.543%

---

Files with Coverage Reduction	New Missed Lines	%
chia/_tests/simulation/test_simulation.py	1	96.45%
chia/util/config.py	1	84.62%
chia/rpc/rpc_server.py	1	89.16%
chia/full_node/full_node.py	1	86.45%
chia/daemon/server.py	7	83.46%

Totals
Change from base Build 13019247618:	0.04%
Covered Lines:	105304
Relevant Lines:	114853

---

💛 - Coveralls

[altendky]

i believe this will indicate an explicit re-export to mypy so we don't have to maintain a __all__.

Suggested change

	from chia.types.node_type import NodeType # TODO: remove this and change a lot of `import` statements
	from chia.types.node_type import NodeType as NodeType # TODO: remove this and change a lot of `import` statements

[richardkiss]

Unfortunately this change is giving me chia/server/outbound_message.py:7:34: PLC0414 Import alias does not rename original package

[altendky]

this is already a thing we intend to correct (per the TODO:) so i think an ignore is reasonable here.

Suggested change

	from chia.types.node_type import NodeType # TODO: remove this and change a lot of `import` statements
	# TODO: remove this and change a lot of `import` statements
	from chia.types.node_type import NodeType as NodeType # noqa: PLC0414

i just really hate maintaining __all__, which won't generally happen i don't think unless some check catches it being out of date. and i despise even more when it is leveraged (* imports).

for example, i did:

https://github.com/Chia-Network/chia_rs/blob/f512dee8c880446faa96972bb78b9c65c250af13/wheel/python/chia_rs/datalayer.pyi#L96-L97

# just disallow * importing so we don't have to maintain this repetitive list
__all__: Sequence[str] = []