Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff and update files #142

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Add ruff and update files #142

merged 11 commits into from
Dec 20, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Dec 18, 2024

Replace black, isort, flake8 and pylint with ruff.
use same ruff.toml as chia-blockchain
update code as needed.

@emlowe emlowe changed the title EL-ruff Add ruff and update files Dec 18, 2024
@emlowe emlowe marked this pull request as ready for review December 18, 2024 22:26
Copy link
Collaborator

@Quexington Quexington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits. Also, it would be good in the future to have some mechanism where if we update the ruff.toml in chia-blockchain, it propagates somehow downstream.

ruff.toml Show resolved Hide resolved
tests/cmds/test_inspect.py Outdated Show resolved Hide resolved
@emlowe
Copy link
Contributor Author

emlowe commented Dec 19, 2024

Adding ruff.toml to the managed files repo might be a good idea - then it would get added to all repos. The downside is making changes to it is more complicated

@emlowe emlowe requested a review from Quexington December 20, 2024 17:33
@emlowe emlowe merged commit 6de9823 into main Dec 20, 2024
31 checks passed
@emlowe emlowe deleted the EL-ruff branch December 20, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants