Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Tests case for Mutation Requirement issue in fusion v1 #8053

Open
wants to merge 1 commit into
base: main-version-15
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 141 additions & 0 deletions src/HotChocolate/Fusion/test/Core.Tests/RequireTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
using System.Diagnostics.CodeAnalysis;
using HotChocolate.Execution;
using HotChocolate.Execution.Processing;
using HotChocolate.Fusion.Composition;
using HotChocolate.Fusion.Composition.Features;
using HotChocolate.Fusion.Metadata;
using HotChocolate.Fusion.Planning;
using HotChocolate.Fusion.Shared;
using HotChocolate.Language;
using HotChocolate.Skimmed.Serialization;
using Microsoft.Extensions.DependencyInjection;
using Xunit.Abstractions;
using static HotChocolate.Fusion.Shared.DemoProjectSchemaExtensions;
using static HotChocolate.Language.Utf8GraphQLParser;
using HttpClientConfiguration = HotChocolate.Fusion.Composition.HttpClientConfiguration;

namespace HotChocolate.Fusion;

public class RequireTests
{
[Fact]
public async Task Require_On_MutationPayload()
{
// arrange
var subgraphA = DemoSubgraph.CreateSubgraphConfig(
"subgraphA",
new Uri("http://localhost:5001"),
"""
type User {
id: ID!
someField: String!
}

type Query {
userById(id: ID!): User
}
"""
);

var subgraphB = DemoSubgraph.CreateSubgraphConfig(
"subgraphB",
new Uri("http://localhost:5002"),
"""
type User {
id: ID!
nestedField(someField: String! @require(field: "someField")): NestedType!
}

type NestedType {
otherField: Int!
}

type Mutation {
createUser: CreateUserPayload
}

type CreateUserPayload {
user: User!
}

type Query {
userById(id: ID!): User @lookup @internal
}
"""
);

var fusionGraph = await FusionGraphComposer.ComposeAsync([subgraphA, subgraphB]);

// act
var result = await CreateQueryPlanAsync(
fusionGraph,
"""
mutation {
createUser {
user {
nestedField {
otherField
}
}
}
}

"""
);

// assert
var snapshot = new Snapshot();
snapshot.Add(result.UserRequest, nameof(result.UserRequest));
snapshot.Add(result.QueryPlan, nameof(result.QueryPlan));
await snapshot.MatchMarkdownAsync();
}

private static async Task<(
DocumentNode UserRequest,
Execution.Nodes.QueryPlan QueryPlan
)> CreateQueryPlanAsync(
Skimmed.SchemaDefinition fusionGraph,
[StringSyntax("graphql")] string query
)
{
var document = SchemaFormatter.FormatAsDocument(fusionGraph);
var context = FusionTypeNames.From(document);
var rewriter = new FusionGraphConfigurationToSchemaRewriter();
var rewritten = rewriter.Rewrite(document, new(context))!;

var services = new ServiceCollection()
.AddGraphQL()
.AddDocumentFromString(rewritten.ToString())
.UseField(n => n);

if (document.Definitions.Any(d => d is ScalarTypeDefinitionNode { Name.Value: "Upload" }))
{
services.AddUploadType();
}

var schema = await services.BuildSchemaAsync();
var serviceConfig = FusionGraphConfiguration.Load(document);

var request = Parse(query);

var operationCompiler = new OperationCompiler(new());
var operationDef = (OperationDefinitionNode)request.Definitions[0];
var operation = operationCompiler.Compile(
new OperationCompilerRequest(
"abc",
request,
operationDef,
schema.GetOperationType(operationDef.Operation)!,
schema
)
);

var queryPlanner = new QueryPlanner(serviceConfig, schema);
var queryPlan = queryPlanner.Plan(operation);

return (request, queryPlan);
}

private static IClientConfiguration[] CreateClients() =>
[new HttpClientConfiguration(new Uri("http://nothing"))];
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Require_On_MutationPayload

## UserRequest

```graphql
mutation {
createUser {
user {
nestedField {
otherField
}
}
}
}
```

## QueryPlan

```json
{
"document": "mutation { createUser { user { nestedField { otherField } } } }",
"rootNode": {
"type": "Sequence",
"nodes": [
{
"type": "Resolve",
"subgraph": "subgraphB",
"document": "mutation fetch_createUser_1 { createUser { user { nestedField { otherField } } } }",
"selectionSetId": 0
},
{
"type": "Compose",
"selectionSetIds": [
0
]
}
]
}
}
```

13 changes: 13 additions & 0 deletions src/HotChocolate/Fusion/test/Shared/DemoSubgraph.cs
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,17 @@ public SubgraphConfiguration ToConfiguration(bool onlyHttp = false)
new WebSocketClientConfiguration(WebSocketEndpointUri),
},
null);

public static SubgraphConfiguration CreateSubgraphConfig(
string name,
Uri httpEndpointUri,
string schema)
=> new(
name,
schema,
[],
[
new HttpClientConfiguration(httpEndpointUri)
],
null);
}
Loading