Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shift key handling when navigating with tab #1245

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

zoglo
Copy link
Contributor

@zoglo zoglo commented Dec 22, 2024

Description

Continuation of #1239

If a search exists within the field, the first shift press would still open the navigation when trying to navigate back using shift + tab.

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@zoglo zoglo changed the title Fix shift key handling on keyboard navigation Fix shift key handling when navigating with tab Dec 22, 2024
@Xon Xon added the bugfix Pull request that fixes an existing bug label Dec 22, 2024
@Xon Xon merged commit 00225b6 into Choices-js:main Dec 22, 2024
10 checks passed
@zoglo zoglo deleted the fix/shift-key-navigation branch December 22, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants