Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move Send Request button to bottom of page #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregorni
Copy link
Contributor

Suggested action buttons should be at the bottom of pages.

@CleoMenezesJr
Copy link
Owner

CleoMenezesJr commented May 24, 2023

It used to be like that, but with AdwActionRow, the button kept going up and down, and even being taken further down where you had to scroll due to the size by default.
image

Btw, I got this idea from Pika Backup.
image

Copy link
Owner

@CleoMenezesJr CleoMenezesJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR depends on more design of the other items. I'm thinking of removing the AdwActionRow.

@gregorni
Copy link
Contributor Author

I'll keep this PR open, maybe to be merged in the future, but feel free to close it yourself if you notice it won't be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants