Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FMS entry for disabling features #79645

Merged

Conversation

RenechCDDA
Copy link
Member

Summary

None

Purpose of change

While this policy has been clearly stated on github, discord, the IN_REPO_MODS.md doc, and many other places, the suggestion keeps coming up that we should just implement 100000000 options to let people disable everything they don't like.

Describe the solution

Write it down right in the FMS. Since this is a frequently made suggestion the frequently made suggestion doc is the best place for it.

Describe alternatives you've considered

The proposed entry does not mention the maintenance burdens, and only addresses issues related to developer work time

Testing

Docs only

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 13, 2025
@RenechCDDA
Copy link
Member Author

It could also do to mention #74053 and other bugs that arise due to having the options. That one was not simple for me to track down, because I always play with hordes on!

@Holli-Git
Copy link
Contributor

I'd include mentioning how maintaining options is a hassle to make sure they actually work, and how having stuff as options can give new players the idea that it's normal to turn off potentially key parts of the game, even if it's not. Also maybe a blip on how people's suggestions for disabling options isn't usually based on anything more than "I do not like/understand this feature", such as with skillrust?

@GuardianDll
Copy link
Member

Adding to what Holli says, we are okay to disable features if they are actually used in the mod and change the game experience, like aftershock disabling EMP ruining your electronic items

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 13, 2025
@RenechCDDA
Copy link
Member Author

Adding to what Holli says, we are okay to disable features if they are actually used in the mod and change the game experience, like aftershock disabling EMP ruining your electronic items

I really don't see a need to mention external options, since those are intended for mod developer. The vast majority of people reading these entries are not going to be mod developers.

@GuardianDll
Copy link
Member

The point is not to highlight external option, the point is to highlight "features are turned off only because they lead to some desired experience"
Sky island turn off player death, effectively, but since it leads to a better experience using the mod, it is allowed, comparing to "revive on death" out of repo mod that does only this - and it is not an external option either

@GuardianDll GuardianDll reopened this Feb 14, 2025
@GuardianDll
Copy link
Member

GuardianDll commented Feb 14, 2025

woops

@NyarlathotepZERO

This comment was marked as abuse.

@kevingranade
Copy link
Member

NyarlathotepZERO if you search for keywords like "options" in the repo you will find that people ask for features, content, and balance to be made optional constantly. Yes not thousands but there are actually hundreds of requests of this kind.

This is not about one thing, this is about an overall policy where if we made the things optional that people request it would be immensely unmaintanable and make the game worse for everyone, so we aren't doing it.

Also your accusations about people's motives are not ok, if you wish to be able to comment here don't repeat that.

@RenechCDDA
Copy link
Member Author

I've pushed another draft. It's meant to take into account the points here, but I urge everyone interested to review it again. I'm sure there will be more changes to make.

@RenechCDDA RenechCDDA force-pushed the FMS_no_disabling_wanted_features branch from 85a8d23 to 42f071b Compare February 22, 2025 08:34
@RenechCDDA RenechCDDA force-pushed the FMS_no_disabling_wanted_features branch from 42f071b to 7ac7dc6 Compare February 22, 2025 08:39
@GuardianDll GuardianDll merged commit 38c73ec into CleverRaven:master Feb 24, 2025
23 checks passed
@RenechCDDA RenechCDDA deleted the FMS_no_disabling_wanted_features branch February 24, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants