Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

nicholasyang2022 · 2024-05-16T07:28:52Z

This pull request implements migrating corosync.conf from corosync 2 to corosync 3, including:

migrate deprecated transport udpu and udp to knet
replace removed feature RRP with knet multilink
if crypto_hash is set to sha1, which is the default value in corosync 2, upgrades it to the new default in corosync 3, sha256.

Use Cases

Check When cluster services are running

> sudo crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[PASS]

------ ha-2-2 ------
[FAIL] Cluster services are running
       * corosync
       * pacemaker

Check When All Green for Migration

> sudo crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[PASS]

------ ha-2-2 ------
[PASS]

Run Migration

> sudo crm cluster health sles16 --fix
------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[PASS]

------ ha-2-2 ------
[PASS]
INFO: Starting migration...
INFO: Migrating corosync configuration...
INFO: Upgrade totem.transport to knet.
INFO: Upgrade totem.crypto_hash from "sha1" to "sha256".
INFO: Finish migrating corosync configuration.
INFO: Finished migration.

codecov · 2024-05-16T07:50:04Z

Codecov Report

Attention: Patch coverage is 66.17336% with 160 lines in your changes missing coverage. Please review.

Project coverage is 69.66%. Comparing base (325350b) to head (7226465).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
crmsh/migration.py	63.59%	150 Missing ⚠️
crmsh/ui_cluster.py	73.68%	10 Missing ⚠️

Additional details and impacted files

Flag	Coverage Δ
integration	`53.76% <65.75%> (+0.21%)`	⬆️
unit	`52.63% <23.67%> (-0.48%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
crmsh/cibquery.py	`100.00% <100.00%> (ø)`
crmsh/corosync.py	`87.64% <100.00%> (ø)`
crmsh/prun/runner.py	`64.86% <100.00%> (+0.97%)`	⬆️
crmsh/sh.py	`92.50% <ø> (+0.41%)`	⬆️
crmsh/xmlutil.py	`69.35% <100.00%> (+0.03%)`	⬆️
crmsh/ui_cluster.py	`74.33% <73.68%> (-0.82%)`	⬇️
crmsh/migration.py	`63.59% <63.59%> (ø)`

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liangxin1300 · 2025-01-03T08:06:32Z

In

# crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[FAIL] Pacemaker version not supported
       Supported version: 3 <= Pacemaker
       Actual version:    Pacemaker == 2.1.9

Supported version: 3 <= Pacemaker better changed similar as Supported version: Pacemaker >= 3

liangxin1300 · 2025-01-03T08:23:52Z

# crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[FAIL] Pacemaker version not supported
       Supported version: 3 <= Pacemaker
       Actual version:    Pacemaker == 2.1.9
[INFO] Checking service status...
[FAIL] Cluster services are running
       * corosync
       * pacemaker
[INFO] Checking used corosync features...

------ alp-3 ------



------ alp-2 ------

No output for remote nodes

zzhou1 · 2025-01-06T06:05:06Z

[FAIL] Cluster services are running
* corosync
* pacemaker

FAIL as the fatal error sounds too strong to me.

No matter it is corosync2 or corosync3 environment, nothing wrong to run crm cluster health sles16 no matter the cluster is running or not.

…#PED-8252) This commit implements: * udpu srp to knet transport migration * udpu rrp to knet multilink migration

…tilink (jsc#PED-8252)

…205925)

…efault

so that it can run in a seperated thread

…8252)

…808) (cherry picked from commit 534b138)

…11808) (cherry picked from commit dc3a0c7)

(cherry picked from commit 0ecf1c6)

(cherry picked from commit d905539)

(cherry picked from commit 8cf8ef3)

(cherry picked from commit 3264f0d)

(cherry picked from commit e656662)

…c#PED-11808) (cherry picked from commit 72cd46f)

(cherry picked from commit 54def35)

…jsc#PED-11808) (cherry picked from commit 7bf54e9)

(cherry picked from commit 84143c4)

…PED-11808) should use recursive queries (cherry picked from commit 4b7e42d)

…ilesystem_with_fstype (cherry picked from commit 48aca45)

(cherry picked from commit 1e48317)

(cherry picked from commit 97fa52b)

as it is not a hard requirement to upgrade pacemaker 2 to 3.

…1808) (cherry picked from commit 8e83574)

nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from 3c620cf to 2d4c6db Compare May 27, 2024 08:05

nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from fdcdc65 to c6cd605 Compare October 23, 2024 03:52

nicholasyang2022 force-pushed the ped-8252-20240516 branch 3 times, most recently from 04ea10f to 69020cc Compare November 1, 2024 04:21

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 69020cc to ab808d1 Compare December 13, 2024 08:00

nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from fa10732 to 68bd445 Compare January 2, 2025 09:14

liangxin1300 mentioned this pull request Jan 3, 2025

[crmsh-4.6] Dev: pre-migration: implement pre-migration checks for SLES 16 (jsc#PED-11808) #1629

Merged

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 68bd445 to 389d007 Compare January 6, 2025 04:54

nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from 486020b to 16cd739 Compare January 23, 2025 07:31

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 16cd739 to e67b67d Compare February 6, 2025 03:49

nicholasyang2022 added 5 commits February 6, 2025 14:46

Dev: migration: implement corosync.conf migration for corosync 3 (jsc…

b6dc057

…#PED-8252) This commit implements: * udpu srp to knet transport migration * udpu rrp to knet multilink migration

Dev: migration: populate node name in corosync node list for knet mul…

e34285e

…tilink (jsc#PED-8252)

Fix: corosync: use os.env instead of os.getenv for consistency (bsc#1…

95cb97a

…205925)

Dev: migration: implement multicast to knet migration (jsc#PED-8252)

748970e

Dev: profiles: set default crypto_hash to sha256 to follow corosync d…

6608cbb

…efault

nicholasyang2022 added 16 commits February 6, 2025 14:46

Dev: ui_cluster: add 'crm cluster health sles [--fix]' (jsc#PED-8252)

140c543

Dev: prun: create event loop manually

6fd5e6c

so that it can run in a seperated thread

Dev: migration: run checks on remote nodes (jsc#PED-8252)

aaaae91

Dev: migration: copy migrated corosync.conf to remote nodes (jsc#PED-…

df7ae39

…8252)

Dev: pre-migration: add checks for used corosync features (jsc#PED-11…

16b1f5c

…808) (cherry picked from commit 534b138)

Dev: pre-migration: check SAPHanaSR Classic resource agents (jsc#PED-…

5384d4f

…11808) (cherry picked from commit dc3a0c7)

Dev: pre-migration: check removed resource agents (jsc#PED-11808)

758a056

(cherry picked from commit 0ecf1c6)

Dev: pre-migration: check removed fence agents (jsc#PED-11808)

ec93b6b

(cherry picked from commit d905539)

Dev: pre-migration: check if ocfs2 is used (jsc#PED-11808)

c8131f7

(cherry picked from commit 8cf8ef3)

Dev: add pre-migration checks for pacemaker version (jsc#PED-11808)

3baa259

(cherry picked from commit 3264f0d)

Dev: pre-migration: do not colorize hostname header (jsc#PED-11808)

5d5eb54

(cherry picked from commit e656662)

Dev: pre-migration: add completer for 'crm cluster health sles16' (js…

ca7051c

…c#PED-11808) (cherry picked from commit 72cd46f)

Fix: ui_cluster: fix do_health usage output

8eac384

(cherry picked from commit 54def35)

Dev: pre-migration: add message about removing stonith:external/sbd (…

20beb4f

…jsc#PED-11808) (cherry picked from commit 7bf54e9)

Doc: ui_cluster: add document for crm cluster health hawk2|sles16

0f66340

(cherry picked from commit 84143c4)

Fix: cibquery: grouped primitives is missing from query results (jsc#…

9cd97a3

…PED-11808) should use recursive queries (cherry picked from commit 4b7e42d)

nicholasyang2022 force-pushed the ped-8252-20240516 branch from e67b67d to 163fac1 Compare February 6, 2025 06:47

nicholasyang2022 added 5 commits February 7, 2025 11:45

Refactor: cibquery: has_primitive_filesystem_ocfs2 to has_primitive_f…

258ee10

…ilesystem_with_fstype (cherry picked from commit 48aca45)

Dev: pre-migration: add summary section to output (jsc#PED-11808)

a7c9f66

(cherry picked from commit 1e48317)

Dev: migration: refine message wording (jsc#PED-11808)

bf9ab60

(cherry picked from commit 97fa52b)

Dev: migration: do not check pacemaker version (jsc#PED-8252)

d85b06d

as it is not a hard requirement to upgrade pacemaker 2 to 3.

Dev: behave: add functional tests for pre-migration checks (jsc#PED-1…

7226465

…1808) (cherry picked from commit 8e83574)

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 163fac1 to 7226465 Compare February 7, 2025 03:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

nicholasyang2022 commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading

liangxin1300 commented Jan 3, 2025

liangxin1300 commented Jan 3, 2025

zzhou1 commented Jan 6, 2025

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Are you sure you want to change the base?

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Conversation

nicholasyang2022 commented May 16, 2024 • edited Loading

Use Cases

Check When cluster services are running

Check When All Green for Migration

Run Migration

codecov bot commented May 16, 2024 • edited Loading

Codecov Report

liangxin1300 commented Jan 3, 2025

liangxin1300 commented Jan 3, 2025

zzhou1 commented Jan 6, 2025

nicholasyang2022 commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading