Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sbd: Detect if sbd package is missing on peer nodes #1636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

When using sbd stage, detect if sbd package is missing on peer nodes

To fix issue #1635

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.74%. Comparing base (155bd2c) to head (c3b252b).

Files with missing lines Patch % Lines
crmsh/bootstrap.py 88.88% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 53.53% <30.00%> (-0.02%) ⬇️
unit 53.10% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/sbd.py 86.82% <100.00%> (ø)
crmsh/bootstrap.py 88.12% <88.88%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review December 19, 2024 06:18
@liangxin1300 liangxin1300 force-pushed the 20241219_sbd_missing_on_stage branch from 21caea9 to c3b252b Compare January 24, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant