Move "set read-only" operation from pre-demote to demote #1006
+25
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pacemaker will call "pre-demote" when its transition start. At this time, some MySQL clients don't stop nomary. They might try to update their status during stop operation, but MySQL is already "read-only" mode. It's better to do "set read-only" at, not "pre-demote" but "demote".
dmuhamedagic
reviewed
Oct 8, 2017
| else | ||
| ocf_log info "Ignoring post-demote notification execpt for my own demotion." | ||
| fi | ||
| ocf_log info "Ignoring pre-demote notification for my own demotion." |
There was a problem hiding this comment.
This log message doesn't seem to be correct, i.e. there's a case of "my demotion" but also one of "demotion of the other".
|
On Sat, Jul 29, 2017 at 10:28:08PM -0700, Junko IKEDA wrote:
Pacemaker will call "pre-demote" when its transition start.
At this time, some MySQL clients don't stop nomary.
"nomary"? Cannot find it in my dictionary ;-)
They might try to update their status during stop operation, but MySQL is already "read-only" mode.
It's better to do "set read-only" at, not "pre-demote" but "demote".
So, set read only at the demote time? Sounds good to me. Perhaps
just reformulate slightly the last sentence.
|
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents-pipeline/job/PR-1006/1/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pacemaker will call "pre-demote" when its transition start.
At this time, some MySQL clients don't stop nomary.
They might try to update their status during stop operation, but MySQL is already "read-only" mode.
It's better to do "set read-only" at, not "pre-demote" but "demote".