High: exportfs: Make fsid optional (bsc#1045161) #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oalbrigt Would be grateful for some extra eyeballs on this one, in particular the |
|
Looks good to me, but I think we should update cleanup_export_cache accordingly as well. |
The fsid export option is not needed any more. There might be some strange corner cases where it can be useful, but it definitely shouldn't be assumed to be needed by default. The `fsid=0` usage used to be important for NFSv4, but this is no longer the case. It is best *not* to use `fsid=0` and to let `exportfs/mountd` create a "NFSv4 pseudo root" themselves. This is (almost) always what is wanted and is least confusing. The `fsid=N N!=0` usage was important some years ago when the device number of hard drives started to change. NFS used to use the device id, which was problematic. Setting an explicit fsid= removed the instability. However for quite some years now NFS has been using the UUID of the filesystem, rather than the device id, to identify a filesystem. So unless you have multiple filesystems with the same uuid, or are using some weird type of filesystem which doesn't have a uuid, `fsid=` isn't needed and is best avoided. So exportfs_test should be changed to not require `fsid=` any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fsid export option is not needed any more. There
might be some strange corner cases where it can be
useful, but it definitely shouldn't be assumed to be
needed by default.
The
fsid=0usage used to be important for NFSv4, butthis is no longer the case. It is best not to use
fsid=0and to letexportfs/mountdcreate a"NFSv4 pseudo root" themselves. This is (almost)
always what is wanted and is least confusing.
The
fsid=N N!=0usage was important some years agowhen the device number of hard drives started to change.
NFS used to use the device id, which was problematic.
Setting an explicit fsid= removed the instability.
However for quite some years now NFS has been using the
UUID of the filesystem, rather than the device id, to
identify a filesystem. So unless you have multiple
filesystems with the same uuid, or are using some weird
type of filesystem which doesn't have a uuid,
fsid=isn't needed and is best avoided.
So exportfs_test should be changed to not require
fsid=any more.