[WIP] podman-etcd: new resource agent #2023
Draft
+1,367
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a resource agent for Podman to manage etcd instances. This agent enables Pacemaker to control etcd containers, handling start, stop, monitor, and recovery operations.
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2023/1/input |
oalbrigt
changed the title
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2023/2/input |
Notes - fixed a couple of places where $? was used instead of $rc - use if is_standalone; instead of if [ $? -eq 0 ] and other functions (and made sure we use rc=$? for cases where rc is used more than once) Changes - use tabs for all indentation - quote string values in if's - move all helper functions before agent's start/stop/monitor/etc command functions - move meta-data/usage|help actions before this section in separate case-statement - removed promote/demote-actions from metadata/usage. can re-add later if we need them - use NODENAME (ocf_local_nodename)/NODEIP instead of $THIS_*/$nodename variables - add crictl to validate-all() binary-checks - cleaned up logging to always have space between : and $var - start() - retry-loop: use break - uncommented #remove_container()-line in stop-action - replace -a in if with && (there are some known issues with using -o/-a in special cases) - podman_notify(): combine the start/stop in case statement
clobrano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a resource agent for Podman to manage etcd instances
This agent enables Pacemaker to control etcd containers, handling start, stop, monitor, and recovery operations.