Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocf:heartbeat:Filesytem - add quotaon/quotaoff support #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bootc
Copy link

@bootc bootc commented Mar 15, 2013

This adds support to ocf:heartbeat:Filesystem to run quotaon at mount time, and quotaoff before unmount.

@lhh
Copy link
Contributor

lhh commented Mar 15, 2013

I like how you did this: do sane things using mount options, unless the administrator turns off automatic "do the right thing" mode. :)

@lhh
Copy link
Contributor

lhh commented Mar 15, 2013

From IRC: Would it be useful to create the quota files if nonexistent, saving the admin a step?

Ex:
https://github.com/bootc/resource-agents/blob/master/rgmanager/src/resources/utils/fs-lib.sh#L450

^ One example of how to create them. Talking with bootc, quotacheck does the file creation for us, touching them individually might not be required.

@bootc
Copy link
Author

bootc commented Mar 15, 2013

Indeed, touching the files before running quotacheck breaks the process. The files must not exist before quotacheck is run for the first time or the process will fail.

Once the actual quota files have been created by quotacheck with the right format, quotacheck will then happily re-check the files when it is run, as long as quota enforcement is turned off for that mountpoint.

@dmuhamedagic
Copy link
Contributor

Any news here? It'd be pity that this doesn't get merged.

@bootc
Copy link
Author

bootc commented Jun 5, 2013

Sorry, I just haven't had a chance to pick this up again properly. I haven't forgotten about it.

@dmuhamedagic
Copy link
Contributor

@bootc, still busy?

@dmuhamedagic dmuhamedagic added this to the 3.9.6-rc1 milestone Jan 2, 2015
@dmuhamedagic
Copy link
Contributor

Looks like @bootc is indefinitely busy. Can anybody else take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants