High: vm.sh: ensure XML domain spec - domain name match

[jnpkrn]

Otherwise, it could happen that the domain specified via xmlfile
is successfully started, but any later action (migration, etc.),
may fail or accidentally manipulate with a different domain(!).

Signed-off-by: Jan Pokorný [email protected]

[guessi]

@jnpkrn,

I've noticed that there's a file permission change in this PR (100755 --> 100644)

should be 0755, right?

[jnpkrn]

@guessi, you are right this was certainly unintended. Quick check discovered another instance of such a side-effect change: PR #424.
On the other hand, this is a violation of unified approach (already violated by SAP{Database,Instance}, not a real issue per-se:
make install will run install utility that sets executable bits automatically and during the build process, we extract the metadata by running bash $AGENT anyway.

[jnpkrn]

That being said, if the maintainer deems appropriate, will fix the perms, indeed.

[guessi]

@jnpkrn
it's just a reminder for pointing out there's unwanted permission changed in this PR :)

and agree, it's not a big issue if permissions were guaranteed by Makefile,

[jnpkrn]

@guessi all in all, good spot, thanks!