Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Route for IPv6 default gateway #927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tbe
Copy link

@tbe tbe commented Feb 5, 2017

The IPv6 ressource checks the "destination" paramter for a ":" to decide if
the route is IPv4 or IPv6. If the destination is "default", it always assumes that
IPv4 is given, even it the gateway has a ":" in it.

The "gateway" parameter is more failsave for this, so we changed the logic to it.

The IPv6 ressource checks the "destination" paramter for a ":" to decide if
the route is IPv4 or IPv6. If the destination is "default", it always assumes that
IPv4 is given, even it the gateway has a ":" in it.

The "gateway" parameter is more failsave for this, so we changed the logic to it.
@dmuhamedagic
Copy link
Contributor

dmuhamedagic commented Feb 13, 2017 via email

@tbe
Copy link
Author

tbe commented Feb 13, 2017

if names are a supported usecase, we would need an additional parameter like "addr_family".

If both, the destination and the gateway are names, we can not decide if the route is ipv4 or ipv6.

@dmuhamedagic
Copy link
Contributor

dmuhamedagic commented Mar 2, 2017 via email

@CAPSLOCK2000
Copy link

This wil fail if destination is an aliased network interface, eg 'ip route add default dev eth0:4'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants