NW6 | Fathi-Kahin | JS-2 | Portfolio | Week 2 #66
Conversation
New task, this time pulling changes from previous module branch. I haven't tested this yet -- am pushing up to pull down and follow the step by step.
no further changes, just a second project added
✅ Deploy Preview for cyf-developer-portfolio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <p class="c-site-footer__text">© 2023 Fathi. All rights reserved.</p> | ||
| </footer> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Great job on using semantic HTML @fhkahin ! Your website's structure is well-organised, thanks to the appropriate use of tags like
, , ,Additionally, achieving a 100% accessibility score (a11y) demonstrates your commitment to inclusivity. Well done 👏
| <p class="c-site-footer__text">© 2023 Fathi Kahin. All rights reserved.</p> | ||
| </footer> | ||
| </body> | ||
| </html> |
| opacity: 1; | ||
| } | ||
| } | ||
| </style> |
There was a problem hiding this comment.
I would suggest avoiding styles here, instead use a separate CSS file for your website's styling(you already have css file). By separating the styles from the HTML code, you can achieve better code organisation and maintainability.
| --paper: hsla(251, 28%, 88%, 0.99); | ||
| --ink: hsla(244, 16%, 17%, 0.95); | ||
| --brand: hsla(0, 79%, 63%, 0.9); | ||
| --font: "Raleway", system-ui, sans-serif; | ||
| --gap: 20px; |
There was a problem hiding this comment.
It's nice to see that you're utilising the standard color codes (all hsla)
| <h1 class="c-site-header__title">Fathi Kahin</h1> | ||
| <p class="c-site-header__subtitle">(Upcoming Software Developer)</p> | ||
| </header> | ||
|
|
||
| <nav aria-label="Main Site Links" class="c-site-nav"> | ||
| <a href="index.html" class="c-site-nav__link">Home</a> | ||
| <a href="/about.html" class="c-site-nav__link">About</a> | ||
| <a href="/projects.html" class="c-site-nav__link">My projects</a> | ||
| <a href="/contact.html" class="c-site-nav__link">Contact</a> | ||
| </nav> | ||
|
|
||
| <main> | ||
| <section> | ||
| <h1 class="c-section__title">List of my Projects</h1> |
There was a problem hiding this comment.
It is considered a good practice to have only one <h1> per page. The <h1> tag represents the main heading of the page and holds significant importance for search engine optimisation and accessibility.
Instead, consider using <h2>, <h3>, and other heading tags to create a hierarchical structure for your headings.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.