-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW-6 | RABIA AVCI | JS1| [TECH ED] Portfolio: branch to branch | WEEK-1 #69
Open
RbAvci
wants to merge
19
commits into
CodeYourFuture:main
Choose a base branch
from
RbAvci:rabia-avci-portfolio-js-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New task, this time pulling changes from previous module branch. I haven't tested this yet -- am pushing up to pull down and follow the step by step.
no further changes, just a second project added
add some styling
✅ Deploy Preview for cyf-developer-portfolio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Mar 25, 2024
RbAvci
changed the title
NW-6 | RABIA ABCI | JS1| [TECH ED] Portfolio: branch to branch | WEEK-1
NW-6 | RABIA AVCI | JS1| [TECH ED] Portfolio: branch to branch | WEEK-1
Mar 25, 2024
pseudopilot
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RbAvci !
Nice work, but I'm not sure why this task is put in JS1 block. It seems to be related to HTML-CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Add github repos to the projects. Add some styling.
Questions
Ask any questions you have for your reviewer.