Add scaling up #191
Open
Add scaling up #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pourianof
changed the title
lib/src/responsive_scaled_box.dart
Outdated
| @@ -40,7 +44,7 @@ class ResponsiveScaledBox extends StatelessWidget { | |||
| padding: scaledViewPadding, insets: scaledViewInsets); | |||
|
|
|||
| Widget childHolder = FittedBox( | |||
| fit: BoxFit.fitWidth, | |||
| fit: BoxFit.cover, | |||
There was a problem hiding this comment.
We can't change this for everyone.
There was a problem hiding this comment.
I fixed and return that back to Boxfit.fitWidth, actually in my tests it doesn't make any difference to output result because of respecting to aspect ratio.
|
Thanks @Coded-By-Pouria , I think this is interesting. There should be a way to do this with the existing API without making a change? Can you wrap the widget with a Transform.scale? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i added a feature which make it possible to designers to work based on certain device size and then scale that render up to current device size if it is larger.
I felt for need and came across this feature when i was working on a Figma template which was designed based on 1540px screen width, and i needed to match my sizes like fonts, column widths, aspect ratios and other stuff with that design and so i first used
ResponsiveScaleBoxwith width 1540 but then i wanted to scale it up to my screen size without any empty borders. So by this feature, i could design based on the figma sizes and then scale up to my screen size.I hope I made my point clear, i'm not native English speaker