Skip to content

Commit

Permalink
Merge pull request #23 from Leanwit/master
Browse files Browse the repository at this point in the history 
[csharp] [booking] Remove unused imports and fix variable name in test
  • Loading branch information
@Leanwit
Leanwit authored Nov 27, 2020
2 parents 6654369 + a9acd1c commit 35aacd5
Show file tree
Hide file tree
Showing 17 changed files with 27 additions and 71 deletions.
4 changes: 1 addition & 3 deletions examples/csharp/csharp-booking-01_base/src/Booking/BookingId.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class BookingId
{
Expand Down
4 changes: 1 addition & 3 deletions examples/csharp/csharp-booking-01_base/src/Booking/CustomerName.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class CustomerName
{
Expand Down
8 changes: 4 additions & 4 deletions examples/csharp/csharp-booking-01_base/test/Booking.Tests/BookingShould.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
[Fact]
private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -52,13 +52,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
new TaxValue(0)
);

Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
}

[Fact]
private void GetTheCorrectStatusWhenTheBookingIsFinished()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -77,7 +77,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
new TaxValue(0)
);

Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
}
}
}
4 changes: 1 addition & 3 deletions examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/BookingId.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class BookingId
{
Expand Down
4 changes: 1 addition & 3 deletions examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/CustomerName.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class CustomerName
{
Expand Down
4 changes: 0 additions & 4 deletions examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/DateRange.cs
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace CodelyTv.Booking
{
Expand Down
8 changes: 1 addition & 7 deletions examples/csharp/csharp-booking-02_introduce_parameter_object/src/Booking/Discount.cs
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class Discount
{
Expand Down
8 changes: 4 additions & 4 deletions ...s/csharp/csharp-booking-02_introduce_parameter_object/test/Booking.Tests/BookingShould.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
[Fact]
private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
new Tax(TaxType.NONE, new TaxValue(0))
);

Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
}

[Fact]
private void GetTheCorrectStatusWhenTheBookingIsFinished()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
new Tax(TaxType.NONE, new TaxValue(0))
);

Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
}
}
}
4 changes: 1 addition & 3 deletions examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/BookingId.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class BookingId
{
Expand Down
4 changes: 1 addition & 3 deletions examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/CustomerName.cs
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class CustomerName
{
Expand Down
4 changes: 0 additions & 4 deletions examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/DateRange.cs
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace CodelyTv.Booking
{
Expand Down
8 changes: 1 addition & 7 deletions examples/csharp/csharp-booking-03_preserve_whole_object/src/Booking/Discount.cs
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class Discount
{
Expand Down
8 changes: 4 additions & 4 deletions examples/csharp/csharp-booking-03_preserve_whole_object/test/Booking.Tests/BookingShould.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
[Fact]
private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
new Tax(TaxType.NONE, new TaxValue(0))
);

Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
}

[Fact]
private void GetTheCorrectStatusWhenTheBookingIsFinished()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
new Tax(TaxType.NONE, new TaxValue(0))
);

Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
}
}
}
5 changes: 1 addition & 4 deletions examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/BookingId.cs
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class BookingId
{
private readonly string value;

public BookingId(string value) => this.value = value;
}

}
5 changes: 1 addition & 4 deletions examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/CustomerName.cs
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
using System;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class CustomerName
{
private readonly string value;

public CustomerName(string value) => this.value = value;
}

}
8 changes: 1 addition & 7 deletions examples/csharp/csharp-booking-04_tell_dont_ask/src/Booking/Discount.cs
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace CodelyTv.Booking
namespace CodelyTv.Booking
{
public sealed class Discount
{
Expand Down
8 changes: 4 additions & 4 deletions examples/csharp/csharp-booking-04_tell_dont_ask/test/Booking.Tests/BookingShould.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ private void GetTheCorrectStatusWhenTheBookingHasNotStartedYet()
[Fact]
private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 6, 29, 15, 0, 0);
var dateBetweenBooking = new DateTime(2020, 6, 29, 15, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -50,13 +50,13 @@ private void GetTheCorrectStatusWhenTheBookingIsCurrentlyActive()
new Tax(TaxType.NONE, new TaxValue(0))
);

Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.ACTIVE, booking.StatusFor(dateBetweenBooking));
}

[Fact]
private void GetTheCorrectStatusWhenTheBookingIsFinished()
{
var dateBeforeBookingHasStarted = new DateTime(2020, 8, 30, 19, 0, 0);
var dateAfterBookingEnds = new DateTime(2020, 8, 30, 19, 0, 0);

var bookingStartDate = new DateTime(2020, 6, 26, 19, 0, 0);
var bookingEndDate = new DateTime(2020, 7, 14, 16, 0, 0);
Expand All @@ -74,7 +74,7 @@ private void GetTheCorrectStatusWhenTheBookingIsFinished()
new Tax(TaxType.NONE, new TaxValue(0))
);

Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateBeforeBookingHasStarted));
Assert.Equal(BookingStatus.FINISHED, booking.StatusFor(dateAfterBookingEnds));
}
}
}

0 comments on commit 35aacd5

Please sign in to comment.