Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Class → Extracted tax and discount logic into BookingPricing. #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Large Class → Extracted tax and discount logic into BookingPricing. #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a7095e
Long Parameter List → Introduced a DTO (BookingDetails).
EduardKrutii Feb 9, 2025
4d665be
Large Class → Extracted tax and discount logic into BookingPricing.
EduardKrutii Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 18 additions & 29 deletions examples/csharp/csharp-booking-01_base/src/Booking/Booking.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,25 @@

namespace CodelyTv.Booking
{
public sealed class Booking
public class BookingPricing
{
private readonly BookingId id;
private readonly DateTime startDate;
private readonly DateTime endDate;
private readonly CustomerId customerId;
private readonly CustomerName customerName;
private readonly EmailAddress customerEmail;
private readonly BookingType bookingType;
private readonly DiscountType discountType;
private readonly DiscountValue discountValue;
private readonly TaxType taxType;
private readonly TaxValue taxValue;
public DiscountType DiscountType { get; }
public DiscountValue DiscountValue { get; }
public TaxType TaxType { get; }
public TaxValue TaxValue { get; }

public Booking(
BookingId id,
DateTime startDate,
DateTime endDate,
CustomerId customerId,
CustomerName customerName,
EmailAddress customerEmail,
BookingType bookingType,
DiscountType discountType,
DiscountValue discountValue,
TaxType taxType,
TaxValue taxValue
)
public BookingPricing(DiscountType discountType, DiscountValue discountValue, TaxType taxType, TaxValue taxValue)
{
DiscountType = discountType;
DiscountValue = discountValue;
TaxType = taxType;
TaxValue = taxValue;
}

private readonly BookingPricing pricing;

public Booking(BookingId id, DateTime startDate, DateTime endDate, CustomerId customerId,
CustomerName customerName, EmailAddress customerEmail, BookingType bookingType, BookingPricing pricing)
{
this.id = id;
this.startDate = startDate;
Expand All @@ -37,10 +29,7 @@ TaxValue taxValue
this.customerName = customerName;
this.customerEmail = customerEmail;
this.bookingType = bookingType;
this.discountType = discountType;
this.discountValue = discountValue;
this.taxType = taxType;
this.taxValue = taxValue;
this.pricing = pricing;
}

public BookingStatus StatusFor(DateTime date)
Expand Down