Keyboard Shortcut improvements #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NET1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
bagusnl
reviewed
Mar 3, 2024
CollapseLauncher/XAMLs/MainApp/Pages/Dialogs/KeyboardShortcuts.cs
Outdated
Show resolved
Hide resolved
19 tasks
gablm
added
Enhancement
- Suppress null warnings - Wrap long lines - Remove unnecessary statement
Bc no save :(
bagusnl
added a commit
that referenced
this pull request
Mar 9, 2024
* [skip ci] Update README.md * Clamp column width if there is no space left This to fix the DataTable component causing a crash due to negative value if small window mode is used. * Enable Rich Presence only after the activated region is set might fix #402 * Fix blurry console icon Also, get the icon from exe rather than a separate ico file * (CodeQA) Theme xaml * Move RPC dispose Adjusted to be in the same file where it is initialized (448ff77) * Change default value displayed for ```Download Threads``` to match the real default value * Auto resize DataTable column width using star L.CRC and R.CRC are hidden in small window mode before this commit. * [skip ci] Update LICENSE and its references * [skip ci] Update SECURITY.md - Added @shatyuka and @gablm to the active maintainers list - Update supported version section * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * HI3 Senadina Game Settings Adjustments (#417) * (GSP) HI3: Adjust to new version * [skip ci] Add more abbreviation list * Use ShouldComputeInputPris on build To try mitigate resource not found error * (GSP) More Hi3 Senadina backend changes * (GSP) Force GraphicsGrade to 6 on Save * (GSP) Docs * (GSP) Senadina frontends and localization * (GSP) Disable preset * CodeQA stuff * Fix crash due to value not exist for ``GraphicsReflectionQuality`` * Move and change Physics toggle to ``ToggleSwitch`` * review adjustments * Review adjustment - Use comparedTo instead of TypeExtensions for Equals() in PhysicsSimulation.cs - Adjustment on comparedTo in GraphicsGrade.cs - Remove unnecessary int declaration in Honkai\RegistryClass\Enums.cs --------- Co-authored-by: Kemal Setya Adhi <[email protected]> Co-authored-by: Ron Friedman <[email protected]> * Add delay for GameBoost Adding 10 seconds before changing the priority to allow for the process to initialize. Also move to its own method to avoid error mixed up with main game launching method error(s). Also also, fix some code QA problems on the changed section because might as well :ahuehue: * Update WindowsAppSDK to 1.5.0 Related #418 * (DiscordRPC) Reset `_firstTimeConnect` for new client * Use Waifu2X to enlarge background image (#412) * Use Waifu2X to enlarge background image * More checks * Resize to window size We will not get pixelated image using MagicScaler * Code cleanup * Rename models folder name * Add some useful logs * Auto detect GPU discrete > integrated > others * Enable OpenMP for speed * [skip ci] Add WAIFU2X.LICENSE and OPENMP.LICENSE * Minor fixes --------- Co-authored-by: Bagus Nur Listiyono <[email protected]> * [skip ci] Use ex variable on GameBoost_Invoke oops... * (CodeQA) SettingsPage - Change copyright year - Sync maintainers - Suppress null scans (take it ReSharper!) - Suppress unrelated Xaml warnings * Stop "open -p" from starting a game when not updated * (Waifu2X) Fix failed test log * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * (Waifu2X) Fix crash on exit * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * Fix CustomBG checkbox logic :derp: * Fix Level of Detail setting order for Hi3 * Read the cache reference from stream for Hi3 * Keyboard Shortcut improvements (#416) * Revamp how shortcuts are saved and fix UI margins * Convert old shortcut list * Minor refactor + Fix KbShortcut related flyout crash * Allow localization of VirtualKeyModifiers * Remove invalid shortcuts and save if the dictionary is altered * Qodana * Parse kbshortcuts .ini only when enabling the shortcuts * Turn DefaultShortcutList into a readonly field * (KbShortcuts) Get GameCount and MaxRegions from Metadata * Remove Equals/HashCode and directly compare values * Update KeyboardShortcuts.cs * No possible multiple enumerations while loading shortcuts * Fix validity check for new shortcut combinations * (KeyboardShortcut) CodeQA - Suppress null warnings - Wrap long lines - Remove unnecessary statement * (KeyboardShortcut) CodeQA part 2 Bc no save :( * (Keyboard Shortcut) Fix opacity animation --------- Co-authored-by: Bagus Nur Listiyono <[email protected]> * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Bump version * Add function to launch game in alt (legacy Collapse) launch mode * Update NuGet(s) - MagicScaler 0.14.0 -> 0.14.2 https://github.com/saucecontrol/PhotoSauce/releases/tag/v0.14.1 https://github.com/saucecontrol/PhotoSauce/releases/tag/v0.14.2 - BuildSDK * Small refactor on HomePage.StartGame - Avoid multiple call on the same parameter - Avoid unnecessary call on unused parameter - Use async overload when disposing ResizableWindowHookToken - Avoid NRE if WatchOutputLog is unexpectedly cancelled before the time - Suppress some NRE --------- Co-authored-by: Ron Friedman <[email protected]> Co-authored-by: Kemal Setya Adhi <[email protected]> Co-authored-by: Gabriel Lima <[email protected]> Co-authored-by: Shatyuka <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Ron Friedman <[email protected]>
bagusnl
added a commit
that referenced
this pull request
Mar 9, 2024
* [skip ci] Update README.md * Clamp column width if there is no space left This to fix the DataTable component causing a crash due to negative value if small window mode is used. * Enable Rich Presence only after the activated region is set might fix #402 * Fix blurry console icon Also, get the icon from exe rather than a separate ico file * (CodeQA) Theme xaml * Move RPC dispose Adjusted to be in the same file where it is initialized (448ff77) * Change default value displayed for ```Download Threads``` to match the real default value * Auto resize DataTable column width using star L.CRC and R.CRC are hidden in small window mode before this commit. * [skip ci] Update LICENSE and its references * [skip ci] Update SECURITY.md - Added @shatyuka and @gablm to the active maintainers list - Update supported version section * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * HI3 Senadina Game Settings Adjustments (#417) * (GSP) HI3: Adjust to new version * [skip ci] Add more abbreviation list * Use ShouldComputeInputPris on build To try mitigate resource not found error * (GSP) More Hi3 Senadina backend changes * (GSP) Force GraphicsGrade to 6 on Save * (GSP) Docs * (GSP) Senadina frontends and localization * (GSP) Disable preset * CodeQA stuff * Fix crash due to value not exist for ``GraphicsReflectionQuality`` * Move and change Physics toggle to ``ToggleSwitch`` * review adjustments * Review adjustment - Use comparedTo instead of TypeExtensions for Equals() in PhysicsSimulation.cs - Adjustment on comparedTo in GraphicsGrade.cs - Remove unnecessary int declaration in Honkai\RegistryClass\Enums.cs --------- Co-authored-by: Kemal Setya Adhi <[email protected]> Co-authored-by: Ron Friedman <[email protected]> * Add delay for GameBoost Adding 10 seconds before changing the priority to allow for the process to initialize. Also move to its own method to avoid error mixed up with main game launching method error(s). Also also, fix some code QA problems on the changed section because might as well :ahuehue: * Update WindowsAppSDK to 1.5.0 Related #418 * (DiscordRPC) Reset `_firstTimeConnect` for new client * Use Waifu2X to enlarge background image (#412) * Use Waifu2X to enlarge background image * More checks * Resize to window size We will not get pixelated image using MagicScaler * Code cleanup * Rename models folder name * Add some useful logs * Auto detect GPU discrete > integrated > others * Enable OpenMP for speed * [skip ci] Add WAIFU2X.LICENSE and OPENMP.LICENSE * Minor fixes --------- Co-authored-by: Bagus Nur Listiyono <[email protected]> * [skip ci] Use ex variable on GameBoost_Invoke oops... * (CodeQA) SettingsPage - Change copyright year - Sync maintainers - Suppress null scans (take it ReSharper!) - Suppress unrelated Xaml warnings * Stop "open -p" from starting a game when not updated * (Waifu2X) Fix failed test log * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * (Waifu2X) Fix crash on exit * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * Fix CustomBG checkbox logic :derp: * Fix Level of Detail setting order for Hi3 * Read the cache reference from stream for Hi3 * Keyboard Shortcut improvements (#416) * Revamp how shortcuts are saved and fix UI margins * Convert old shortcut list * Minor refactor + Fix KbShortcut related flyout crash * Allow localization of VirtualKeyModifiers * Remove invalid shortcuts and save if the dictionary is altered * Qodana * Parse kbshortcuts .ini only when enabling the shortcuts * Turn DefaultShortcutList into a readonly field * (KbShortcuts) Get GameCount and MaxRegions from Metadata * Remove Equals/HashCode and directly compare values * Update KeyboardShortcuts.cs * No possible multiple enumerations while loading shortcuts * Fix validity check for new shortcut combinations * (KeyboardShortcut) CodeQA - Suppress null warnings - Wrap long lines - Remove unnecessary statement * (KeyboardShortcut) CodeQA part 2 Bc no save :( * (Keyboard Shortcut) Fix opacity animation --------- Co-authored-by: Bagus Nur Listiyono <[email protected]> * [skip ci] Sync translation Translate en_US.json in es_419 100% reviewed source file: 'en_US.json' on 'es_419'. * [skip ci] Sync translation Translate en_US.json in ja_JP 100% reviewed source file: 'en_US.json' on 'ja_JP'. * [skip ci] Sync translation Translate en_US.json in zh_CN 100% reviewed source file: 'en_US.json' on 'zh_CN'. * [skip ci] Bump version * Add function to launch game in alt (legacy Collapse) launch mode * Update NuGet(s) - MagicScaler 0.14.0 -> 0.14.2 https://github.com/saucecontrol/PhotoSauce/releases/tag/v0.14.1 https://github.com/saucecontrol/PhotoSauce/releases/tag/v0.14.2 - BuildSDK * Small refactor on HomePage.StartGame - Avoid multiple call on the same parameter - Avoid unnecessary call on unused parameter - Use async overload when disposing ResizableWindowHookToken - Avoid NRE if WatchOutputLog is unexpectedly cancelled before the time - Suppress some NRE --------- Co-authored-by: Ron Friedman <[email protected]> Co-authored-by: Kemal Setya Adhi <[email protected]> Co-authored-by: Gabriel Lima <[email protected]> Co-authored-by: Shatyuka <[email protected]> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Ron Friedman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the current Keyboards Shortcuts module.
Shortcuts are now stored in a dictionary.
Fixes some margins in the UI
Allows translation of the strings "Ctrl", "Alt" and "Shift" show in the shortcuts menu.