Preview 1.82.15 Release #676

bagusnl · 2025-01-26T14:25:39Z

NOTE:

THIS RELEASE WILL BE STAGED.
STABLE WILL GET IT SOONER OR LATER, BUT NOT NOW WRYYYYYYYYYYYYYYYYYYYYYYYY

What's changed? - 1.82.15

[Fix] Taskbar progress did not disappear after game install/update, by @shatyuka
[Imp] Use Persistent folder for Audio VO when possible, by @neon-nyan
[Fix] Lock .NET SDK version to 9.0.1, by @bagusnl
[New] Check for UAC availability status, by @shatyuka
- UAC is needed for the game, when it's disabled it might give "Anti cheat error" message and refusing to run the game
- Please do not use debloat scripts/ISOs
- i beg you
[Imp] CodeQA based on Qodana and ReSharper suggestions, by @neon-nyan
[New] Introducing Hash extension for hashing FileStream, string, Span<T> and FileInfo with both synchronous and asynchronous version of the methods. The methods uses generic type of any member of HashAlgorithm (Such as: MD5, SHA*, HMACSHA*, etc.) and NonCryptographicHashAlgorithm (Such as: Crc32, XxHash*, etc.) to specify which kind of hash to be used, by @neon-nyan
- do not worry, i dont understand this either <-- @bagusnl
[Imp] Separating InternalAppJSONContext members into its own JsonContext, by @neon-nyan
[Imp] Update H.NotifyIcon to work with CsWin32 v0.3.162, by @neon-nyan
[Imp] Update NuGet packages, by @neon-nyan & @bagusnl
[Imp] Recompile and Update StaticLibs for NativeAOT libraries link, by @neon-nyan
- Update Rust compiler for csharp_bindings to rustc 1.84.0 (9fc6b4312 2025-01-07) (Stable)
- Remove dependency to MSVCRT library (Manual VC++ 2019/2022 Redist installation should no longer be needed) and fully utilize UCRT as its runtime library.
- Update libwebp libraries to: https://github.com/webmproject/libwebp/tree/f8f241071001e1a3807f34a26a03a742ea843458
- Favor speed + inline optimizaton build (/O2 + /Ob2 + /Oi + /Ot)
- Recompile all static libraries using Microsoft Visual C++ 2022 (19.43.34618) compiler.
- Optimize Rust library, csharp_bindings to use full LTO.
[Imp] Update Hi3Helper.Sophon submodule, by @neon-nyan
[Imp] Switch from managed Process to directly use Win32 APIs on ProcessChecker, by @neon-nyan
[Imp] [ZZZ GSP] Change High-Precision Character Animation option from Checkbox to ComboBox and add two other options: Dynamic and Global, by @neon-nyan
[Loc] Sync locales, by localizers <3

Templates

Changelog Prefixes

  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

100% reviewed source file: 'en_US.json' on 'ja_JP'.

100% reviewed source file: 'en_US.json' on 'vi_VN'.

Sometimes the user have other audio packages installed on game, which will be stored into persistent folder instead.

+ Also make it to create the Hash instance based on its generic type

not more debloat please

100% reviewed source file: 'en_US.json' on 'zh_CN'.

100% reviewed source file: 'en_US.json' on 'ja_JP'.

100% reviewed source file: 'en_US.json' on 'vi_VN'.

100% reviewed source file: 'en_US.json' on 'id_ID'.

Also remove all hashing method dependency from Hi3Helper.EncTool

100% reviewed source file: 'en_US.json' on 'es_419'.

tryfix aot builds failing due to outdated ilcompiler package

Forcing build to not fallback a version, which will fail itself

+ Update Rust compiler for csharp_bindings to rustc 1.84.0 (9fc6b4312 2025-01-07) (Stable) + Remove dependency to MSVCRT library (Manual VC++ 2019/2022 Redist installation should no longer be needed) + Update libwebp libraries to: https://github.com/webmproject/libwebp/tree/f8f241071001e1a3807f34a26a03a742ea843458 + Favor size build + Recompile using MSVC 2022 (19.43.34618)

+ As per changes from 1.4 -> 1.5, the GI has been set to low for Low preset

+ Use indentation on serializing the JSON

100% reviewed source file: 'en_US.json' on 'id_ID'.

GamePresetProperty.GetGameProcessWithActiveWindow -> ProcessChecker.TryGetProcessIdWithActiveWindow

bagusnl · 2025-01-27T15:00:04Z

@CollapseLauncher/core-maintainers besides the codeQA mentioned above, is there any other blocking for this staging?

+ Tho, this won't fix an issue where process priority can't get set due to Anti-cheat's process protection

neon-nyan · 2025-01-27T15:22:56Z

@CollapseLauncher/core-maintainers besides the codeQA mentioned above, is there any other blocking for this staging?

My last commit has been pushed. Nothing from me so far

bagusnl · 2025-01-27T15:24:59Z

i guess there is #671 and #672
but knowing the amount of changes in this one, should we call it or na?

neon-nyan · 2025-01-27T15:27:27Z

i guess there is #671 and #672 but knowing the amount of changes in this one, should we call it or na?

It's not reproducible anymore on my end for #672. We can push it as another feature for both stable and preview in 1.82.16 for #671, since this 1.82.15 is only for preview due to changes on CodeQA and backend

Cryotechnic · 2025-01-27T15:30:55Z

i guess there is #671 and #672 but knowing the amount of changes in this one, should we call it or na?

It's not reproducible anymore on my end for #672. We can push it as another feature for both stable and preview in 1.82.16 for #671, since this 1.82.15 is only for preview due to changes on CodeQA and backend

IMO, we should keep #672 open until next cache update feature compatible game patch (HSR or other); I've had this issue come up too but since I've cleaned the files, I can't validate if a working fix has been implemented.

bagusnl · 2025-01-27T15:43:17Z

Noted, please proceed after Qodana is taken care of

aV_2luV1txM2WoU6.mp4

neon hated it so much he tried to purged it :)

100% reviewed source file: 'en_US.json' on 'es_419'.

github-actions · 2025-01-27T16:28:15Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

100% reviewed source file: 'en_US.json' on 'ja_JP'.

Such wow, more CodeQA

sonarqubecloud · 2025-01-27T20:49:30Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarQube Cloud

ISTG.... PLEASE MAKE IT THE LAST :pepehands:

sentry-io · 2025-02-03T18:45:52Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ System.Text.RegularExpressions.RegexMatchTimeoutException: RegexMatchTimeoutException_Occurred XAMLs\Theme\CustomControls\CommunityToolkit.Lab... View Issue

_{Did you find this useful? React with a 👍 or 👎}

neon-nyan and others added 30 commits January 14, 2025 22:28

[skip ci] Update README.md

bc88757

[skip ci] Sync translation Translate en_US.json in ja_JP

0d047e8

100% reviewed source file: 'en_US.json' on 'ja_JP'.

[skip ci] Sync translation Translate en_US.json in vi_VN

e7de2d2

100% reviewed source file: 'en_US.json' on 'vi_VN'.

Apply for persistent audio patch if possible

2a44755

Sometimes the user have other audio packages installed on game, which will be stored into persistent folder instead.

Fix taskbar progress does not disappear after game installation

1fe7d00

Update Hi3Helper.Sophon

8f6d2b1

Separate hashing method to its own Hash class

4cb4fe0

+ Also make it to create the Hash instance based on its generic type

Split GamePresetProperty into its own file

b9f048f

GamePropertyVault and GamePresetProperty CodeQA

afb0c05

CodeQA

43123b0

Fix compile error

83bac13

Check UAC status

da68876

not more debloat please

[skip ci] Sync translation Translate en_US.json in zh_CN

f80d385

100% reviewed source file: 'en_US.json' on 'zh_CN'.

[skip ci] Sync translation Translate en_US.json in ja_JP

b6f670f

100% reviewed source file: 'en_US.json' on 'ja_JP'.

[skip ci] Sync translation Translate en_US.json in vi_VN

6bbb694

100% reviewed source file: 'en_US.json' on 'vi_VN'.

[skip ci] Sync translation Translate en_US.json in id_ID

f4e5729

100% reviewed source file: 'en_US.json' on 'id_ID'.

Add more hashing methods on Hash helper

25bec28

Also remove all hashing method dependency from Hi3Helper.EncTool

[skip ci] Sync translation Translate en_US.json in es_419

0790696

100% reviewed source file: 'en_US.json' on 'es_419'.

[Hash] Revert Generic boxing on Hash creation methods

8effb69

Update Nungget

c79b961

tryfix aot builds failing due to outdated ilcompiler package

Explicitly tell ILCompiler version

381e4a4

Forcing build to not fallback a version, which will fail itself

Huge CodeQA

f6bb961

Huge CodeQA (pt. 2)

bf43788

Fix compilation error

5444f36

Huge CodeQA (pt. 3)

cf8e639

Use per-class JSONContext

d449d81

Rename JSONContext -> JsonContext

778c70c

Update H.NotifyIcon to support latest CsWinRT

144fea7

Make Api*HttpClient always be non-nullable

dd36d94

neon-nyan and others added 7 commits January 26, 2025 23:07

[ZZZ GSP] Change Global Illumination to Low on Low preset

9753a66

+ As per changes from 1.4 -> 1.5, the GI has been set to low for Low preset

Rent buffer while eeping (coz I hab no moneh)

ff65890

[ZZZ GSP] Keep unknown properties on serialization

1c34ebd

+ Use indentation on serializing the JSON

[skip ci] Sync translation Translate en_US.json in id_ID

8de77f3

100% reviewed source file: 'en_US.json' on 'id_ID'.

Replace managed process APIs with ProcessChecker

c298505

GamePresetProperty.GetGameProcessWithActiveWindow -> ProcessChecker.TryGetProcessIdWithActiveWindow

Fix get active window check

014b339

Ensure dispose the Process after using

a79b7c5

Use ProcessChecker API to set process priority

0d7f1e1

+ Tho, this won't fix an issue where process priority can't get set due to Anti-cheat's process protection

Bump version

fdfe725

neon-nyan and others added 4 commits January 27, 2025 23:01

CodeQA (pls, this is the last one)

1a94d95

[skip ci] Bring back Qodana Scan PR

0ec5be8

Bring back Qodana scanner

c29b660

neon hated it so much he tried to purged it :)

[skip ci] Sync translation Translate en_US.json in es_419

81aa640

100% reviewed source file: 'en_US.json' on 'es_419'.

neon-nyan and others added 6 commits January 28, 2025 00:14

XAML and .cs CodeQA

5f2495b

[skip ci] Sync translation Translate en_US.json in ja_JP

26e94b9

100% reviewed source file: 'en_US.json' on 'ja_JP'.

Much more CodeQA

412c4ac

Such wow, more CodeQA

Fix SonarQube CodeQA issue

fe27db8

CodeQA (again)

90f9a72

Another (one) CodeQA

5460fd2

Another F-Ing CodeQA

56c25bf

ISTG.... PLEASE MAKE IT THE LAST :pepehands:

neon-nyan merged commit b63b8d3 into preview Jan 28, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preview 1.82.15 Release #676

Preview 1.82.15 Release #676

bagusnl commented Jan 26, 2025 •

edited by neon-nyan

Loading

bagusnl commented Jan 27, 2025

neon-nyan commented Jan 27, 2025

bagusnl commented Jan 27, 2025

neon-nyan commented Jan 27, 2025 •

edited

Loading

Cryotechnic commented Jan 27, 2025

bagusnl commented Jan 27, 2025

github-actions bot commented Jan 27, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 27, 2025

sentry-io bot commented Feb 3, 2025

Preview 1.82.15 Release #676

Preview 1.82.15 Release #676

Conversation

bagusnl commented Jan 26, 2025 • edited by neon-nyan Loading

NOTE:

What's changed? - 1.82.15

Templates

bagusnl commented Jan 27, 2025

neon-nyan commented Jan 27, 2025

bagusnl commented Jan 27, 2025

neon-nyan commented Jan 27, 2025 • edited Loading

Cryotechnic commented Jan 27, 2025

bagusnl commented Jan 27, 2025

github-actions bot commented Jan 27, 2025 • edited Loading

Qodana for .NET

sonarqubecloud bot commented Jan 27, 2025

Quality Gate passed

sentry-io bot commented Feb 3, 2025

Suspect Issues

bagusnl commented Jan 26, 2025 •

edited by neon-nyan

Loading

neon-nyan commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading