Add maintenance task logging

Comfy-Org · Jan 29, 2025 · 6370c58 · 6370c58
1 parent 3f82e55
commit 6370c58
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/install/installationManager.ts b/src/install/installationManager.ts
@@ -96,7 +96,10 @@ export class InstallationManager {
         });
       }
     };
-    const sendLogIpc = (data: string) => this.appWindow.send(IPC_CHANNELS.LOG_MESSAGE, data);
+    const sendLogIpc = (data: string) => {
+      log.info(data);
+      this.appWindow.send(IPC_CHANNELS.LOG_MESSAGE, data);
+    };
 
     ipcMain.handle(IPC_CHANNELS.GET_VALIDATION_STATE, () => {
       installation.onUpdate?.(installation.validation);

diff --git a/src/virtualEnvironment.ts b/src/virtualEnvironment.ts
@@ -596,7 +596,8 @@ export class VirtualEnvironment implements HasTelemetry {
     try {
       await this.#using(() => this.ensurePip(callbacks));
       return true;
-    } catch {
+    } catch (error) {
+      log.error('Failed to upgrade pip:', error);
       return false;
     }
   }
@@ -610,7 +611,8 @@ export class VirtualEnvironment implements HasTelemetry {
       const callbacks: ProcessCallbacks = { onStdout: onData };
       await this.#using(() => this.createVenvWithPython(callbacks));
       return true;
-    } catch {
+    } catch (error) {
+      log.error('Failed to create virtual environment:', error);
       return false;
     }
   }