Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pypi mirror usage in virtualEnvironment.ts #751

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Fix pypi mirror usage in virtualEnvironment.ts #751

merged 5 commits into from
Jan 28, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 28, 2025

Ref: Comfy-Org/ComfyUI_frontend#2333 (comment)

UV does not accept Pypi env variable. The Pypi mirror should be used as index-url when invoking pip command.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner January 28, 2025 17:49
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 28, 2025
@dosubot dosubot bot added the bug Something isn't working label Jan 28, 2025
@huchenlei huchenlei merged commit f8f5eac into main Jan 28, 2025
2 checks passed
@huchenlei huchenlei deleted the fix_pypi branch January 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant